You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/30 04:55:15 UTC

[GitHub] [ignite-python-thin-client] rjemanuele opened a new pull request #36: Incorrect type hint for the cache's get_all

rjemanuele opened a new pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36


   The docs for get_all show it returning a dict but the return type hint was erroneously a list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-python-thin-client] ivandasch commented on pull request #36: Incorrect type hint for the cache's get_all

Posted by GitBox <gi...@apache.org>.
ivandasch commented on pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36#issuecomment-837893970


   @rjemanuele Hi! Do you need any help to resolve this issue? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-python-thin-client] ivandasch commented on pull request #36: Incorrect type hint for the cache's get_all

Posted by GitBox <gi...@apache.org>.
ivandasch commented on pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36#issuecomment-833371348


   @rjemanuele I have added you to contributors group and assigned ticket to you
   
   Could you please also rename PR by prepending jira ticket id 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-python-thin-client] ivandasch closed pull request #36: IGNITE-14686 Incorrect type hint for the cache's get_all

Posted by GitBox <gi...@apache.org>.
ivandasch closed pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-python-thin-client] ivandasch commented on pull request #36: Incorrect type hint for the cache's get_all

Posted by GitBox <gi...@apache.org>.
ivandasch commented on pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36#issuecomment-833365888


   I have meant `pyignite.aio_cache.AioCache`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-python-thin-client] ivandasch commented on pull request #36: Incorrect type hint for the cache's get_all

Posted by GitBox <gi...@apache.org>.
ivandasch commented on pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36#issuecomment-829878699


   Hi, thank you, but could you please
   1. Register in apache jira and file a ticket (i.e. lile this https://issues.apache.org/jira/browse/IGNITE-14444)
   2. Assign it to yourself
   3. Make aame change to AioCache?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-python-thin-client] ivandasch edited a comment on pull request #36: Incorrect type hint for the cache's get_all

Posted by GitBox <gi...@apache.org>.
ivandasch edited a comment on pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36#issuecomment-829878699


   Hi, thank you, but could you please
   1. Register in apache jira and file a ticket (i.e. like this https://issues.apache.org/jira/browse/IGNITE-14444)
   2. Assign it to yourself
   3. Make the same change to AioCache?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-python-thin-client] rjemanuele commented on pull request #36: Incorrect type hint for the cache's get_all

Posted by GitBox <gi...@apache.org>.
rjemanuele commented on pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36#issuecomment-833156179


   @ivandasch Thank you for the instructions.
   
   1. I've created an issue: https://issues.apache.org/jira/browse/IGNITE-14686
   2. I am not sure how to assign it to myself.
   3.  As far as I can tell https://github.com/aio-libs/aiocache does not support IGNITE's thin-client protocol; AIOCache only seems to support IGNITE's memcached emulation interface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-python-thin-client] ivandasch commented on pull request #36: IGNITE-14686 Incorrect type hint for the cache's get_all

Posted by GitBox <gi...@apache.org>.
ivandasch commented on pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36#issuecomment-856788853


   @rjemanuele Thank you, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-python-thin-client] ivandasch edited a comment on pull request #36: Incorrect type hint for the cache's get_all

Posted by GitBox <gi...@apache.org>.
ivandasch edited a comment on pull request #36:
URL: https://github.com/apache/ignite-python-thin-client/pull/36#issuecomment-829878699


   Hi, thank you, but could you please
   1. Register in apache jira and file a ticket (i.e. lile this https://issues.apache.org/jira/browse/IGNITE-14444)
   2. Assign it to yourself
   3. Make the same change to AioCache?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org