You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/06/09 05:14:54 UTC
[kudu-CR] Always write last known addr into ConsensusMetadata
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3349
to review the following change.
Change subject: Always write last_known_addr into ConsensusMetadata
......................................................................
Always write last_known_addr into ConsensusMetadata
Since we did not always do this for masters, implement migration code to
set a default at startup time if it does not exist.
Change-Id: I82ac67d49b6318b2d5f2524d7ebb36241d50cccc
---
M src/kudu/master/sys_catalog.cc
1 file changed, 27 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3349/1
--
To view, visit http://gerrit.cloudera.org:8080/3349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82ac67d49b6318b2d5f2524d7ebb36241d50cccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
[kudu-CR] Always write last known addr into ConsensusMetadata
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: Always write last_known_addr into ConsensusMetadata
......................................................................
Abandoned
abandoning this one
--
To view, visit http://gerrit.cloudera.org:8080/3349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I82ac67d49b6318b2d5f2524d7ebb36241d50cccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Always write last known addr into ConsensusMetadata
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Always write last_known_addr into ConsensusMetadata
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3349/1/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:
PS1, Line 134: Distributed mode disabled but there is more than one peer "
: "in the Raft config
Does this imply that if you set up multi-master, it's not possible to temporarily run one of the nodes as a local master? That's unfortunate as it could be a useful workaround for when say 2 out of 3 masters have died and we still want to make forward progress.
Line 144: // TODO: Consider replacing this "migration hack" with something more clever?
Why do we actually need this? The RPC addresses of the entire master Raft configuration must be provided to each master at start up time. And as per KUDU-418, we're probably going to remove last_known_addr from RaftPeerPB anyway.
--
To view, visit http://gerrit.cloudera.org:8080/3349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ac67d49b6318b2d5f2524d7ebb36241d50cccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Always write last known addr into ConsensusMetadata
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Always write last_known_addr into ConsensusMetadata
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/1793/
--
To view, visit http://gerrit.cloudera.org:8080/3349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ac67d49b6318b2d5f2524d7ebb36241d50cccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Always write last known addr into ConsensusMetadata
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Always write last_known_addr into ConsensusMetadata
......................................................................
Patch Set 1:
I'm actually not quite sure about this solution. It works for now but it may not work well for multi-homed master hosts. We don't really have a solution for that and we likely need to do more work on it as part of the HA master work.
--
To view, visit http://gerrit.cloudera.org:8080/3349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ac67d49b6318b2d5f2524d7ebb36241d50cccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No