[GitHub] [pinot] walterddr commented on a change in pull request #7485: Fix pql double quote checker exception

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #7485:
URL: https://github.com/apache/pinot/pull/7485#discussion_r716050653



##########
File path: pinot-core/src/test/java/org/apache/pinot/core/data/function/InbuiltFunctionEvaluatorTest.java
##########
@@ -120,10 +128,27 @@ public void testStateSharedBetweenRowsForExecution()
     assertEquals(evaluator.evaluate(row), "test test test ");
   }
 
+  @Test
+  public void testExceptionDuringInbuiltFunctionEvaluator()
+      throws Exception {
+    String expression = "fromDateTime('2020-01-01T00:00:00Z', \"invalid_identifier\")";
+    InbuiltFunctionEvaluator evaluator = new InbuiltFunctionEvaluator(expression);
+    assertEquals(1, evaluator.getArguments().size());

Review comment:
       geeze.. this is revert convention from junit!!!!
   http://junit.sourceforge.net/javadoc/org/junit/Assert.html
   https://www.javadoc.io/doc/org.testng/testng/6.8.17/org/testng/Assert.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org