You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2019/11/21 02:01:53 UTC

[GitHub] [logging-log4j2] supertomcat commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

supertomcat commented on issue #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…
URL: https://github.com/apache/logging-log4j2/pull/314#issuecomment-556832195
 
 
   > 
   > 
   > You'll need some kind of unit test to show what was broken and is now fixed.
   
   I'd love to provide one, but I wouldn't know how. To create a unit test for this case, I'd have to be able to mock NetUtils.getMacAddress() and return a longer than six bytes mac address. But that is not possible, because NetUtils is a final Utility class.
   
   I documented in the Jira issue what exactly was broken and will be fixed by this Pull-Request. I hope this will be enough to get this Pull-Request merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services