You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "deeppatel710 (via GitHub)" <gi...@apache.org> on 2026/04/08 06:32:53 UTC
[PR] Upstream fork ingestion freshness [pinot]
deeppatel710 opened a new pull request, #18126:
URL: https://github.com/apache/pinot/pull/18126
Addresses review feedback from #15782 (Jackie-Jiang):
- Converted `RealtimeOffsetAutoResetHandler` from abstract class to interface with an `init(PinotLLCRealtimeSegmentManager, PinotHelixResourceManager)` method
for post-construction initialization
- Removed constructor injection from `RealtimeOffsetAutoResetKafkaHandler`; initialization now happens via `init()` called by the manager after reflective
instantiation
- Fixed `ensureBackfillJobsRunning` signature: `List<String>` → `Collection<String>` to match the interface contract
- Updated `RealtimeOffsetAutoResetManager.getOrConstructHandler()` to use no-arg constructor + `init()` instead of constructor injection via reflection
- Fixed bug in `nonLeaderCleanup()`: was not clearing `_tableEphemeralTopics`, leaving stale state when the controller re-acquires leadership
## Changes
| File | Change |
|---|---|
| `RealtimeOffsetAutoResetHandler.java` | Abstract class → interface; added `init()` |
| `RealtimeOffsetAutoResetKafkaHandler.java` | Implements interface; removed constructor; fixed `Collection<String>` signature |
| `RealtimeOffsetAutoResetManager.java` | Uses no-arg constructor + `init()`; fixed `nonLeaderCleanup()` |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Upstream fork ingestion freshness [pinot]
Posted by "deeppatel710 (via GitHub)" <gi...@apache.org>.
deeppatel710 closed pull request #18126: Upstream fork ingestion freshness
URL: https://github.com/apache/pinot/pull/18126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org