You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/04/07 17:31:36 UTC
[GitHub] [hbase] saintstack opened a new pull request #1450: HBASE-24126 Up
the container nproc uplimit from 10000 to 12500
saintstack opened a new pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-611210061
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 48s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 2m 33s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1450 |
| Optional Tests | |
| uname | Linux ddb109d14920 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / eb7df0498c |
| Max. process+thread count | 52 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405890340
##########
File path: dev-support/hbase_nightly_yetus.sh
##########
@@ -66,7 +66,7 @@ YETUS_ARGS=("--branch=${BRANCH_NAME}" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--tests-filter=${TESTS_FILTER}" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--ignore-unknown-options=true" "${YETUS_ARGS[@]}")
# Why are these not being picked up from hbase-personality?
-YETUS_ARGS=("--proclimit=10000" "${YETUS_ARGS[@]}")
+YETUS_ARGS=("--proclimit=12500" "${YETUS_ARGS[@]}")
Review comment:
Yeah. For now they needed. Let me file an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-610526938
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 14s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 2m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1450 |
| Optional Tests | |
| uname | Linux 7f68ff9e6500 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 80d4a09ddc |
| Max. process+thread count | 52 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405636546
##########
File path: dev-support/hbase-personality.sh
##########
@@ -513,6 +516,7 @@ function hadoopcheck_parse_args
## @stability evolving
function hadoopcheck_docker_support
{
+ DOCKER_EXTRAARGS=("${DOCKER_EXTRAARGS[@]}" "--ulimit" "nproc=12500")
Review comment:
I don't think this should be here. we want this proc limit change all the time, not just when the hadoopcheck test is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405827202
##########
File path: dev-support/hbase-personality.sh
##########
@@ -513,6 +516,7 @@ function hadoopcheck_parse_args
## @stability evolving
function hadoopcheck_docker_support
{
+ DOCKER_EXTRAARGS=("${DOCKER_EXTRAARGS[@]}" "--ulimit" "nproc=12500")
Review comment:
Let me push new patch w/ your change. Thanks @busbey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405872153
##########
File path: dev-support/flaky-tests/flaky-reporting.Jenkinsfile
##########
@@ -43,7 +43,7 @@ pipeline {
flaky_args=("${flaky_args[@]}" --urls "${JENKINS_URL}/job/HBase%20Nightly/job/${BRANCH_NAME}" --is-yetus True --max-builds 10)
flaky_args=("${flaky_args[@]}" --urls "${JENKINS_URL}/job/HBase-Flaky-Tests/job/${BRANCH_NAME}" --is-yetus False --max-builds 30)
docker build -t hbase-dev-support dev-support
- docker run -v "${WORKSPACE}":/hbase --workdir=/hbase hbase-dev-support python dev-support/flaky-tests/report-flakies.py --mvn -v "${flaky_args[@]}"
+ docker run --ulimit nproc=12500 -v "${WORKSPACE}":/hbase --workdir=/hbase hbase-dev-support python dev-support/flaky-tests/report-flakies.py --mvn -v "${flaky_args[@]}"
Review comment:
Yikes. This is just hiding over here in the corner. TODO: update flaky reporting to use yetus to run builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-611209888
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| -0 :warning: | shellcheck | 0m 3s | The patch generated 1 new + 9 unchanged - 1 fixed = 10 total (was 10) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 1s | ASF License check generated no output? |
| | | 2m 10s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1450 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 8a6b878b04bf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / eb7df0498c |
| shellcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/artifact/yetus-general-check/output/diff-patch-shellcheck.txt |
| Max. process+thread count | 44 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-611209423
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405890055
##########
File path: dev-support/flaky-tests/flaky-reporting.Jenkinsfile
##########
@@ -43,7 +43,7 @@ pipeline {
flaky_args=("${flaky_args[@]}" --urls "${JENKINS_URL}/job/HBase%20Nightly/job/${BRANCH_NAME}" --is-yetus True --max-builds 10)
flaky_args=("${flaky_args[@]}" --urls "${JENKINS_URL}/job/HBase-Flaky-Tests/job/${BRANCH_NAME}" --is-yetus False --max-builds 30)
docker build -t hbase-dev-support dev-support
- docker run -v "${WORKSPACE}":/hbase --workdir=/hbase hbase-dev-support python dev-support/flaky-tests/report-flakies.py --mvn -v "${flaky_args[@]}"
+ docker run --ulimit nproc=12500 -v "${WORKSPACE}":/hbase --workdir=/hbase hbase-dev-support python dev-support/flaky-tests/report-flakies.py --mvn -v "${flaky_args[@]}"
Review comment:
Yeah, one way to run all builds would be sweet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-610526618
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| -0 :warning: | shellcheck | 0m 2s | The patch generated 1 new + 9 unchanged - 1 fixed = 10 total (was 10) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 2m 18s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1450 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 3a17135ae434 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 80d4a09ddc |
| shellcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt |
| Max. process+thread count | 47 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405704576
##########
File path: dev-support/hbase-personality.sh
##########
@@ -513,6 +516,7 @@ function hadoopcheck_parse_args
## @stability evolving
function hadoopcheck_docker_support
{
+ DOCKER_EXTRAARGS=("${DOCKER_EXTRAARGS[@]}" "--ulimit" "nproc=12500")
Review comment:
I don't follow. The new 12500 number is put everywhere, not just here conditional on when hadoopcheck runs. Thanks for taking a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-613058593
bq. Oops. I meant to say that you found a bug in our personality, not in Yetus. That wasn't clear in my earlier comment.
Took me a while but now I get what you meant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-612273878
After push, I went to file issue against YETUS and noticed YETUS expects PROC_LIMIT, not PROCLIMIT as I have in our personality (an old error but relevant here). I reverted. Let me see if using PROC_LIMIT instead helps here. New PR coming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405874635
##########
File path: dev-support/hbase_nightly_yetus.sh
##########
@@ -66,7 +66,7 @@ YETUS_ARGS=("--branch=${BRANCH_NAME}" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--tests-filter=${TESTS_FILTER}" "${YETUS_ARGS[@]}")
YETUS_ARGS=("--ignore-unknown-options=true" "${YETUS_ARGS[@]}")
# Why are these not being picked up from hbase-personality?
-YETUS_ARGS=("--proclimit=10000" "${YETUS_ARGS[@]}")
+YETUS_ARGS=("--proclimit=12500" "${YETUS_ARGS[@]}")
Review comment:
If the above change for `PROC_LIMIT` works, this line can be dropped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-610527388
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 56s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 44s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 3m 43s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1450 |
| Optional Tests | |
| uname | Linux 0d85475155a2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 80d4a09ddc |
| Max. process+thread count | 47 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405873034
##########
File path: dev-support/hbase_docker.sh
##########
@@ -159,4 +159,4 @@ done
echo "Successfully built ${IMAGE_NAME}."
Review comment:
Oh no, I didn't know this script existed. I probably broke it with the improvements that went in with HBASE-23945.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-612276131
> After push, I went to file issue against YETUS and noticed YETUS expects PROC_LIMIT, not PROCLIMIT as I have in our personality (an old error but relevant here). I reverted. Let me see if using PROC_LIMIT instead helps here. New PR coming.
Oops. I meant to say that you found a bug in our personality, not in Yetus. That wasn't clear in my earlier comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-611209948
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 2m 16s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1450 |
| Optional Tests | |
| uname | Linux 1caf84c7e2b3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / eb7df0498c |
| Max. process+thread count | 52 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-610525831
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405874678
##########
File path: dev-support/jenkins_precommit_github_yetus.sh
##########
@@ -102,7 +102,7 @@ YETUS_ARGS+=("--reapermode=kill")
# set relatively high limits for ASF machines
# changing these to higher values may cause problems
# with other jobs on systemd-enabled machines
-YETUS_ARGS+=("--proclimit=10000")
+YETUS_ARGS+=("--proclimit=12500")
Review comment:
likewise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405730607
##########
File path: dev-support/hbase-personality.sh
##########
@@ -513,6 +516,7 @@ function hadoopcheck_parse_args
## @stability evolving
function hadoopcheck_docker_support
{
+ DOCKER_EXTRAARGS=("${DOCKER_EXTRAARGS[@]}" "--ulimit" "nproc=12500")
Review comment:
the reference you've added here is in the function that defines what is needed when we run docker specifically _just_ when we're doing the hadoopcheck test.
if we need it all the time, then it should be elsewhere. It looks it should be coming in from the YETUS_ARGS that have been added to the wrapper. If that's the case, then removing it here should have no impact on what happens. If removing it here makes it so things don't do what you expect, then something else is broken because the inclusion here is only going to happen when the hadoopcheck test is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-610525832
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-611209396
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-611205574
Address @busbey comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405890250
##########
File path: dev-support/hbase-personality.sh
##########
@@ -81,8 +81,11 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ # NOTE: I don't think changing this has an effect. Set the
+ # --proclimit passed to yetus. This seems to do what we
+ # need changing proclimit.
Review comment:
Let me try filing an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-611209486
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/2/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack merged pull request #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack merged pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1450:
HBASE-24126 Up the container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405874437
##########
File path: dev-support/hbase-personality.sh
##########
@@ -81,8 +81,11 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ # NOTE: I don't think changing this has an effect. Set the
+ # --proclimit passed to yetus. This seems to do what we
+ # need changing proclimit.
Review comment:
Ah, yeah. [In yetus](https://github.com/apache/yetus/blob/8b44644/precommit/src/main/shell/test-patch.sh#L96), the env variable is `PROC_LIMIT`. You found a bug :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-610666383
Will merge this to master in morning unless objection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#issuecomment-610525749
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1450/1/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services