You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/12/17 00:40:23 UTC
Review Request 29126: Make 'pants goal' invocations work. Use proper
python codegen style.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29126/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Make 'pants goal' invocations work. Use proper python codegen style.
Diffs
-----
BUILD.tools PRE-CREATION
pants.ini 3927f28a657c61adf14c6f62da963f02e8c76e59
Diff: https://reviews.apache.org/r/29126/diff/
Testing
-------
./pants goal test src/test/python/apache/aurora/client/api:updater
Thanks,
Brian Wickman
Re: Review Request 29126: Make 'pants goal' invocations work. Use
proper python codegen style.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29126/#review65261
-----------------------------------------------------------
Ship it!
Master (95ad0fa) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 16, 2014, 11:57 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29126/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 11:57 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make 'pants goal' invocations work. Use proper python codegen style.
>
>
> Diffs
> -----
>
> BUILD.tools PRE-CREATION
> pants.ini 3927f28a657c61adf14c6f62da963f02e8c76e59
>
> Diff: https://reviews.apache.org/r/29126/diff/
>
>
> Testing
> -------
>
> ./pants goal test src/test/python/apache/aurora/client/api:updater
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 29126: Make 'pants goal' invocations work. Use
proper python codegen style.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29126/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 11:57 p.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
Add TODO to BUILD.tools
Repository: aurora
Description
-------
Make 'pants goal' invocations work. Use proper python codegen style.
Diffs (updated)
-----
BUILD.tools PRE-CREATION
pants.ini 3927f28a657c61adf14c6f62da963f02e8c76e59
Diff: https://reviews.apache.org/r/29126/diff/
Testing
-------
./pants goal test src/test/python/apache/aurora/client/api:updater
Thanks,
Brian Wickman
Re: Review Request 29126: Make 'pants goal' invocations work. Use
proper python codegen style.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29126/#review65260
-----------------------------------------------------------
Ship it!
BUILD.tools
<https://reviews.apache.org/r/29126/#comment108333>
Mind adding a TODO to remove this (it's a workaround for https://github.com/pantsbuild/pants/issues/867).
- Kevin Sweeney
On Dec. 16, 2014, 3:40 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29126/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 3:40 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make 'pants goal' invocations work. Use proper python codegen style.
>
>
> Diffs
> -----
>
> BUILD.tools PRE-CREATION
> pants.ini 3927f28a657c61adf14c6f62da963f02e8c76e59
>
> Diff: https://reviews.apache.org/r/29126/diff/
>
>
> Testing
> -------
>
> ./pants goal test src/test/python/apache/aurora/client/api:updater
>
>
> Thanks,
>
> Brian Wickman
>
>