You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/01/04 04:07:17 UTC

Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55160/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-6134
    https://issues.apache.org/jira/browse/MESOS-6134


Repository: mesos


Description
-------

Added test for DockerContainerizer when `cgroups_enable_cfs` is set.


Diffs
-----

  src/tests/containerizer/docker_containerizer_tests.cpp 4e3b67bbb989f9084dfdf4970839956dcb0caa0e 

Diff: https://reviews.apache.org/r/55160/diff/


Testing
-------

Run the new test.


Thanks,

Zhitao Li

Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55160/#review164224
-----------------------------------------------------------



Bad patch!

Reviews applied: [55160, 51052, 54821]

Failed command: python support/apply-reviews.py -n -r 51052

Error:
2017-02-04 02:02:48 URL:https://reviews.apache.org/r/51052/diff/raw/ [7027/7027] -> "51052.patch" [1]
error: patch failed: src/docker/docker.cpp:513
error: src/docker/docker.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/16972/console

- Mesos Reviewbot


On Feb. 3, 2017, 7:34 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55160/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 7:34 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6134
>     https://issues.apache.org/jira/browse/MESOS-6134
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for DockerContainerizer when `cgroups_enable_cfs` is set.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 31d63b1f239055d82470ace9024b584a2096dce4 
> 
> Diff: https://reviews.apache.org/r/55160/diff/
> 
> 
> Testing
> -------
> 
> Run the new test.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

Posted by haosdent huang <ha...@apache.org>.


> On Feb. 6, 2017, 5:50 a.m., haosdent huang wrote:
> >

Test in CentOS 7.2.

This looks pretty good expect some nits. Let's commit it after 1.2.0 release.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55160/#review164308
-----------------------------------------------------------


On Feb. 5, 2017, 11:09 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55160/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2017, 11:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6134
>     https://issues.apache.org/jira/browse/MESOS-6134
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for DockerContainerizer when `cgroups_enable_cfs` is set.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 31d63b1f239055d82470ace9024b584a2096dce4 
> 
> Diff: https://reviews.apache.org/r/55160/diff/
> 
> 
> Testing
> -------
> 
> Run the new test.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

Posted by haosdent huang <ha...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55160/#review164308
-----------------------------------------------------------




src/tests/containerizer/docker_containerizer_tests.cpp (line 39)
<https://reviews.apache.org/r/55160/#comment235995>

    Nit: Add an extra blank line here.



src/tests/containerizer/docker_containerizer_tests.cpp (line 40)
<https://reviews.apache.org/r/55160/#comment235996>

    Nit: Add an extra line here.
    
    ```
    #include "slave/containerizer/fetcher.hpp"
    
    #include "slave/containerizer/mesos/isolators/cgroups/constants.hpp"
    ```



src/tests/containerizer/docker_containerizer_tests.cpp (line 4083)
<https://reviews.apache.org/r/55160/#comment236000>

    the test filter `CGROUPS_CFS_` is required for this test case.



src/tests/containerizer/docker_containerizer_tests.cpp (line 4095)
<https://reviews.apache.org/r/55160/#comment236001>

    `"cpus:1;mem:128"` should be enough?



src/tests/containerizer/docker_containerizer_tests.cpp (lines 4193 - 4199)
<https://reviews.apache.org/r/55160/#comment236002>

    I think we could replace this with
    
    ```
    Try<Duration> cfsQuota = cgroups::cpu::cfs_quota_us(cpuHierarchy.get(), cpuCgroup.get());
    ```



src/tests/containerizer/docker_containerizer_tests.cpp (line 4201)
<https://reviews.apache.org/r/55160/#comment236003>

    should we use a better name, `expectedCpuQuota` and `cpuQuota`?



src/tests/containerizer/docker_containerizer_tests.cpp (lines 4211 - 4213)
<https://reviews.apache.org/r/55160/#comment236004>

    This seems uncessary.


- haosdent huang


On Feb. 5, 2017, 11:09 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55160/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2017, 11:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6134
>     https://issues.apache.org/jira/browse/MESOS-6134
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for DockerContainerizer when `cgroups_enable_cfs` is set.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 31d63b1f239055d82470ace9024b584a2096dce4 
> 
> Diff: https://reviews.apache.org/r/55160/diff/
> 
> 
> Testing
> -------
> 
> Run the new test.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55160/#review164289
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54821, 51052, 55160]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 5, 2017, 11:09 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55160/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2017, 11:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6134
>     https://issues.apache.org/jira/browse/MESOS-6134
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for DockerContainerizer when `cgroups_enable_cfs` is set.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 31d63b1f239055d82470ace9024b584a2096dce4 
> 
> Diff: https://reviews.apache.org/r/55160/diff/
> 
> 
> Testing
> -------
> 
> Run the new test.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>