You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/22 03:54:32 UTC

[GitHub] sandeep-krishnamurthy commented on a change in pull request #12786: Set correct update on kvstore flag in dist_device_sync mode

sandeep-krishnamurthy commented on a change in pull request #12786: Set correct update on kvstore flag in dist_device_sync mode
URL: https://github.com/apache/incubator-mxnet/pull/12786#discussion_r226898440
 
 

 ##########
 File path: python/mxnet/gluon/trainer.py
 ##########
 @@ -269,13 +273,13 @@ def step(self, batch_size, ignore_stale_grad=False):
             If true, ignores Parameters with stale gradient (gradient that has not
             been updated by `backward` after last step) and skip update.
         """
+        self._optimizer.rescale_grad = self._scale / batch_size
 
 Review comment:
   Update the PR with warning message. Thanks for pointing this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services