You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nicolas Spiegelberg (JIRA)" <ji...@apache.org> on 2011/08/19 02:38:27 UTC
[jira] [Created] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Modify the webUI so that default values of column families are not shown
------------------------------------------------------------------------
Key: HBASE-4227
URL: https://issues.apache.org/jira/browse/HBASE-4227
Project: HBase
Issue Type: Improvement
Reporter: Nicolas Spiegelberg
Assignee: nileema shingte
Priority: Minor
Fix For: 0.92.0
With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "nileema shingte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nileema shingte updated HBASE-4227:
-----------------------------------
Attachment: HBASE-4227.patch
Addressed Stack's comments.
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch, HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "nileema shingte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087506#comment-13087506 ]
nileema shingte commented on HBASE-4227:
----------------------------------------
Yes, it should be a static map. I will send across a new patch for this.
Thanks for the prompt review, Stack!
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "nileema shingte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nileema shingte updated HBASE-4227:
-----------------------------------
Attachment: HBASE-4227.patch
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "nileema shingte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090309#comment-13090309 ]
nileema shingte commented on HBASE-4227:
----------------------------------------
I will create a patch for this with a describe 'table_name' and describe_details 'table_name'
(former will print only non-default values and latter will print all)
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch, HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "nileema shingte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nileema shingte updated HBASE-4227:
-----------------------------------
Release Note:
This patch addresses the following:
1. On the master web UI, the table description lists out only column families with non-default values.
2. A details link through which the complete table description is available.
Status: Patch Available (was: Open)
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090799#comment-13090799 ]
stack commented on HBASE-4227:
------------------------------
I'd say don't worry about it Nileema. What I think I really want is that when I do a scan on .META., I only see non-default values too. The shell recognizes when Scan is of a .META. and when we are on the info:regioninfo, it decodes the bytes as an HRegionInfo and dumps it all out default values and all. This can be a bunch of repitition. I just need to change it so I filter out the default values somehow. Thanks for offering though to make the change (I like this change in the UI).
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch, HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087617#comment-13087617 ]
Hudson commented on HBASE-4227:
-------------------------------
Integrated in HBase-TRUNK #2126 (See [https://builds.apache.org/job/HBase-TRUNK/2126/])
HBASE-4227 Modify the webUI so that default values of column families are not shown
stack :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/resources/hbase-webapps/master/tablesDetailed.jsp
* /hbase/trunk/src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch, HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087500#comment-13087500 ]
stack commented on HBASE-4227:
------------------------------
Looks great. getDefaultValues looks like it should be a static map though, what you think Nileema? Something like:
{code}
private final static Map<String, String> DEFAULT_VALUES = new HashMap<String, String>();
static {
defaultValues.put(BLOOMFILTER, DEFAULT_BLOOMFILTER);
DEFAULT_VALUES.put(REPLICATION_SCOPE, String.valueOf(DEFAULT_REPLICATION_SCOPE));
DEFAULT_VALUES.put(HConstants.VERSIONS, String.valueOf(DEFAULT_VERSIONS));
DEFAULT_VALUES.put(COMPRESSION, DEFAULT_COMPRESSION);
DEFAULT_VALUES.put(TTL, String.valueOf(DEFAULT_TTL));
DEFAULT_VALUES.put(BLOCKSIZE, String.valueOf(DEFAULT_BLOCKSIZE));
DEFAULT_VALUES.put(HConstants.IN_MEMORY, String.valueOf(DEFAULT_IN_MEMORY));
DEFAULT_VALUES.put(BLOCKCACHE, String.valueOf(DEFAULT_BLOCKCACHE));
}
{code}
No biggie. I can commit w/o it but if you make a new patch that'd be good too. Thanks.
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089972#comment-13089972 ]
stack commented on HBASE-4227:
------------------------------
Can we have this for shell too?
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch, HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4227) Modify the webUI so that default
values of column families are not shown
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4227:
-------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Nice patch Nileema (I tried it out and it helps UI display nicely). Committed to trunk.
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch, HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more advantageous to put configuration knobs at the column family level vs global configuration settings. This will create a nasty web UI experience for showing table properties unless we default to showing the custom values instead of all values. It's on the table if we want to modify the shell's 'describe' method as well. scan '.META.' should definitely return the full properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira