[GitHub] [arrow-rs] alamb opened a new issue #150: Document use of unsafe in remaining files

[GitBox <gi...@apache.org>]

alamb opened a new issue #150:
URL: https://github.com/apache/arrow-rs/issues/150


   *Note*: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-10981
   
   There are ~11 uses of unsafe in the following files and we should document them according to the guidelines in the Arrow crate README
   {code:java}
    ./arrow/src/bytes.rs:5
    ./arrow/src/arch/avx512.rs:4
    ./arrow/src/bitmap.rs:1
    ./arrow/src/zz_memory_check.rs:1 {code}
   {code:java}
   // JUSTIFICATION
   //  Benefit
   //      Describe the benefit of using unsafe. E.g.
   //      "30% performance degradation if the safe counterpart is used, see bench X."
   //  Soundness
   //      Describe why the code remains sound (according to the definition of rust's unsafe code guidelines). E.g.
   //      "We bounded check these values at initialization and the array is immutable."
   let ... = unsafe { ... }; 
   
   {code}
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org