You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/05 02:41:01 UTC

[GitHub] [tvm] czh978 commented on pull request #12593: [Frontend][TFLite] fix detection_postprocess's non_max_suppression_attrs["force_suppress"]

czh978 commented on PR #12593:
URL: https://github.com/apache/tvm/pull/12593#issuecomment-1236490798

   > Thanks for adding a test case @czh978. I'm happy for this to be merged once CI is green.
   > 
   > The last thing we need is for the PR description to be improved with a description of your findings that as `use_regular_nms` is set as `False` in TVM, we need to have `force_supress` to be `True`, to avoid all detections to be suppressed.
   > 
   > Please expand that with the reasoning why this change is needed and point out that it reproduces on networks like ssd_mobilenet_v2 and other examples if you know any.
   
   I've modified the commit message to meet the requirements of the new RFC, could you review it if you're available?Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org