You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/26 11:45:14 UTC

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5140: change: the install target to ensure it is only called by luarocks

leslie-tsang commented on a change in pull request #5140:
URL: https://github.com/apache/apisix/pull/5140#discussion_r716191371



##########
File path: Makefile
##########
@@ -164,8 +164,8 @@ reload: default
 	$(OR_EXEC) -p $$PWD/  -c $$PWD/conf/nginx.conf -s reload
 
 
-### install:          Install the apisix (only for luarocks)
-.PHONY: install
+### install-by-luarocks:	Install the apisix (only for luarocks)
+.PHONY: install-by-luarocks
 install: default

Review comment:
       ```suggestion
   install-by-luarocks: default
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org