You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by istudens <gi...@git.apache.org> on 2015/10/22 14:26:47 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-274 ActiveMQThreadFactory h...
GitHub user istudens opened a pull request:
https://github.com/apache/activemq-artemis/pull/211
ARTEMIS-274 ActiveMQThreadFactory has to be constructed within doPriv…
…ileged block
https://issues.apache.org/jira/browse/ARTEMIS-274
This fix is related to
https://issues.jboss.org/browse/WFLY-5166
https://issues.jboss.org/browse/JBEAP-814
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/istudens/activemq-artemis JBEAP-814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #211
----
commit 32834634e436410004c2453b3b020ff86d9996db
Author: Ivo Studensky <is...@redhat.com>
Date: 2015-10-22T12:22:41Z
ARTEMIS-274 ActiveMQThreadFactory has to be constructed within doPrivileged block
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-274 ActiveMQThreadFactory h...
Posted by istudens <gi...@git.apache.org>.
Github user istudens commented on the pull request:
https://github.com/apache/activemq-artemis/pull/211#issuecomment-150231246
Ah, thanks. I will do it better next time ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-274 ActiveMQThreadFactory h...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/211#issuecomment-150230616
There was one checkstyle issue.. but I fixed here.
You could double check it by using the -Pdev profile
```sh
mvn install -Pdev install -DskipTests=true
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-274 ActiveMQThreadFactory h...
Posted by istudens <gi...@git.apache.org>.
Github user istudens commented on the pull request:
https://github.com/apache/activemq-artemis/pull/211#issuecomment-150225404
It most likely can be simplified as you pointed out. I was following the WildFly code where it was done exactly as I did and I was not sure if it was done this way for a good reason or not. David Lloyd might know more. It partially came out of his (untracked in jira) change in JBossThreadFactory.
Feel free to change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-274 ActiveMQThreadFactory h...
Posted by istudens <gi...@git.apache.org>.
Github user istudens commented on the pull request:
https://github.com/apache/activemq-artemis/pull/211#issuecomment-150225817
Hopefully there is no checkstyle issue in my fix. I converted my IDE settings to 3-spaces for working with Artemis project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-274 ActiveMQThreadFactory h...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-274 ActiveMQThreadFactory h...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/211#issuecomment-150224242
I will merge this, but i will first ammend the checkstyle issue, and the change I asked here...
I will run the entire testsuite first.. so it will take me 1 hour before I can merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---