You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/04/14 01:21:18 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #40787: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsOnConnect`
zhengruifeng opened a new pull request, #40787:
URL: https://github.com/apache/spark/pull/40787
### What changes were proposed in this pull request?
Skip `TorchDistributorLocalUnitTestsOnConnect`
### Why are the changes needed?
it seems that `TorchDistributorLocalUnitTestsOnConnect` is also unstable, but I can repro the issue locally, this needs more investigation
### Does this PR introduce _any_ user-facing change?
no, test-only
### How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40787: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsOnConnect`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40787:
URL: https://github.com/apache/spark/pull/40787#issuecomment-1507938724
Great! Thank you, @zhengruifeng ! That's all we need in order to not to forget.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40787: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsOnConnect`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40787:
URL: https://github.com/apache/spark/pull/40787#issuecomment-1507813457
```
Finished test(python3.9): pyspark.ml.tests.connect.test_parity_torch_distributor (192s) ... 10 tests were skipped
Starting test(python3.9): pyspark.sql.tests.connect.streaming.test_parity_streaming (temp output: /__w/spark/spark/python/target/6548aa9a-508e-4527-8485-90f50f29fc9f/python3.9__pyspark.sql.tests.connect.streaming.test_parity_streaming__dqdzlp2m.log)
```
right now the local mode related tests are disabled in connect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40787: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsOnConnect`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40787:
URL: https://github.com/apache/spark/pull/40787#issuecomment-1507937784
@dongjoon-hyun I created https://issues.apache.org/jira/browse/SPARK-43122 for the disabled tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40787: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsOnConnect`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40787: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsOnConnect`
URL: https://github.com/apache/spark/pull/40787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40787: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsOnConnect`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40787:
URL: https://github.com/apache/spark/pull/40787#issuecomment-1507800484
also track it in https://issues.apache.org/jira/browse/SPARK-43122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40787: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsOnConnect`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40787:
URL: https://github.com/apache/spark/pull/40787#issuecomment-1507812967
cc @HyukjinKwon @WeichenXu123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40787: [SPARK-42994][TESTS][FOLLOWUP] Skip `TorchDistributorLocalUnitTestsOnConnect`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40787:
URL: https://github.com/apache/spark/pull/40787#issuecomment-1507878070
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org