You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Everett Toews <no...@github.com> on 2013/10/11 19:29:00 UTC
[jclouds] ServiceType for Marconi/Cloud Queues. (#176)
https://issues.apache.org/jira/browse/JCLOUDS-340
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds queue-service-type
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/176
-- Commit Summary --
* ServiceType for Marconi/Cloud Queues.
-- File Changes --
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/v2_0/ServiceType.java (9)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseAccessTest.java (83)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseRackspaceAccessTest.java (13)
M apis/openstack-keystone/src/test/resources/keystoneAuthResponse.json (14)
M apis/openstack-keystone/src/test/resources/raxAuth.json (16)
M apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v2_0/ServiceType.java (7)
M apis/rackspace-cloudidentity/src/test/resources/rackspaceAuthResponse.json (18)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/176.patch
https://github.com/jclouds/jclouds/pull/176.diff
Re: [jclouds] ServiceType for Marconi/Cloud Queues. (#176)
Posted by Everett Toews <no...@github.com>.
jclouds-pull-requests failed on the timing test BlockUntilInitScriptStatusIsZeroThenReturnOutputTest.testloopUntilTrueOrThrowCancellationExceptionReturnsWhenPredicateIsTrueSecondTimeWhileNotCancelled
buildhive jclouds and jclouds-java-7-pull-requests passed it. Going with best 2 out of 3.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/176#issuecomment-26161333
Re: [jclouds] ServiceType for Marconi/Cloud Queues. (#176)
Posted by Everett Toews <no...@github.com>.
> .service(Service.builder().name("reddwarf").type(DATABASE_SERVICE)
> .endpoint(Endpoint.builder()
> - .publicURL("http://172.16.0.1:8776/v1/3456")
> - .tenantId("123123")
> - .region("RegionOne").build()).build())
> + .publicURL("http://172.16.0.1:8776/v1/3456")
> + .tenantId("123123")
> + .region("RegionOne").build()).build())
Ya. The formatting was a mess. Still is. Formatting improved in proposed commit https://github.com/rackspace/jclouds/commit/cec5d4d57369d756ec7bea5a59e73f0ed3c51b79
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/176/files#r6946063
Re: [jclouds] ServiceType for Marconi/Cloud Queues. (#176)
Posted by Andrew Phillips <no...@github.com>.
> .service(Service.builder().name("reddwarf").type(DATABASE_SERVICE)
> .endpoint(Endpoint.builder()
> - .publicURL("http://172.16.0.1:8776/v1/3456")
> - .tenantId("123123")
> - .region("RegionOne").build()).build())
> + .publicURL("http://172.16.0.1:8776/v1/3456")
> + .tenantId("123123")
> + .region("RegionOne").build()).build())
Above is cleanup?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/176/files#r6931633
Re: [jclouds] ServiceType for Marconi/Cloud Queues. (#176)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #298](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/298/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/176#issuecomment-26159344
Re: [jclouds] ServiceType for Marconi/Cloud Queues. (#176)
Posted by Andrew Phillips <no...@github.com>.
> @@ -31,13 +31,7 @@
> import org.jclouds.rest.annotations.SelectJson;
> import org.testng.annotations.Test;
>
> -import static org.jclouds.openstack.v2_0.ServiceType.BLOCK_STORAGE;
> -import static org.jclouds.openstack.v2_0.ServiceType.COMPUTE;
> -import static org.jclouds.openstack.v2_0.ServiceType.DATABASE_SERVICE;
> -import static org.jclouds.openstack.v2_0.ServiceType.IDENTITY;
> -import static org.jclouds.openstack.v2_0.ServiceType.IMAGE;
> -import static org.jclouds.openstack.v2_0.ServiceType.NETWORK;
> -import static org.jclouds.openstack.v2_0.ServiceType.OBJECT_STORE;
> +import static org.jclouds.openstack.v2_0.ServiceType.*;
Do we have a "policy" on `*` imports?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/176/files#r6931630
Re: [jclouds] ServiceType for Marconi/Cloud Queues. (#176)
Posted by Andrew Phillips <no...@github.com>.
> @@ -57,7 +57,12 @@
> public static final String BLOCK_STORAGE = "volume";
>
> /**
> - * Database Service (RedDwarf)
> + * Database Service (Trove)
I'm guessing these two changes are not really related, but fine by me to have them here...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/176/files#r6931627
Re: [jclouds] ServiceType for Marconi/Cloud Queues. (#176)
Posted by Everett Toews <no...@github.com>.
> @@ -31,13 +31,7 @@
> import org.jclouds.rest.annotations.SelectJson;
> import org.testng.annotations.Test;
>
> -import static org.jclouds.openstack.v2_0.ServiceType.BLOCK_STORAGE;
> -import static org.jclouds.openstack.v2_0.ServiceType.COMPUTE;
> -import static org.jclouds.openstack.v2_0.ServiceType.DATABASE_SERVICE;
> -import static org.jclouds.openstack.v2_0.ServiceType.IDENTITY;
> -import static org.jclouds.openstack.v2_0.ServiceType.IMAGE;
> -import static org.jclouds.openstack.v2_0.ServiceType.NETWORK;
> -import static org.jclouds.openstack.v2_0.ServiceType.OBJECT_STORE;
> +import static org.jclouds.openstack.v2_0.ServiceType.*;
Not that I've ever seen documented anywhere but the policy should probably be no * imports. This was my IDE playing fun tricks on me. I've put a stop to that. Individual imports in proposed commit https://github.com/rackspace/jclouds/commit/cec5d4d57369d756ec7bea5a59e73f0ed3c51b79
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/176/files#r6946041
Re: [jclouds] ServiceType for Marconi/Cloud Queues. (#176)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #760](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/760/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/176#issuecomment-26159442
Re: [jclouds] ServiceType for Marconi/Cloud Queues. (#176)
Posted by Sam Harwell <no...@github.com>.
> .service(Service.builder().name("reddwarf").type(DATABASE_SERVICE)
> .endpoint(Endpoint.builder()
> - .publicURL("http://172.16.0.1:8776/v1/3456")
> - .tenantId("123123")
> - .region("RegionOne").build()).build())
> + .publicURL("http://172.16.0.1:8776/v1/3456")
> + .tenantId("123123")
> + .region("RegionOne").build()).build())
To ease reviewing, please make whitespace-only changes their own commit(s).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/176/files#r7429558