You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhongqiangczq (via GitHub)" <gi...@apache.org> on 2023/02/16 04:44:29 UTC
[GitHub] [incubator-celeborn] zhongqiangczq opened a new pull request, #1241: [CELEBORN-307] fix ArrayComparisonFailure while running lz4 ut
zhongqiangczq opened a new pull request, #1241:
URL: https://github.com/apache/incubator-celeborn/pull/1241
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
pushmergedata chooses a random shuffleclient ,but pushdata only choose a specfic shuffleclient.
the defaut value of celeborn.data.io.numConnectionsPerPeer is 2, so the client maybe different between pushdata and pushmergedata.
Two shuffleclient means two threads to send message and worker server will has two threads to flush, so the data in the file maybe unorder. lastly, Assert.assertArrayEquals(targetArr, readBytes) will occur error because the data is unorder.
so set celeborn.data.io.numConnectionsPerPeer to 1 to slove the problem above
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1241: [CELEBORN-307] fix ArrayComparisonFailure while running lz4 ut
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1241:
URL: https://github.com/apache/incubator-celeborn/pull/1241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1241: [CELEBORN-307] fix ArrayComparisonFailure while running lz4 ut
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1241:
URL: https://github.com/apache/incubator-celeborn/pull/1241#issuecomment-1432509957
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1241?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1241](https://codecov.io/gh/apache/incubator-celeborn/pull/1241?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21284f0) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/318157e3e9e2a4b9ffdada4a59779772f9ebd205?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (318157e) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1241 +/- ##
============================================
- Coverage 27.22% 27.20% -0.01%
+ Complexity 806 804 -2
============================================
Files 212 212
Lines 18000 18000
Branches 1966 1966
============================================
- Hits 4899 4896 -3
Misses 12777 12777
- Partials 324 327 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `69.27% <0.00%> (-2.45%)` | :arrow_down: |
| [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `77.93% <0.00%> (+1.36%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org