You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by András Piros via Review Board <no...@reviews.apache.org> on 2018/03/19 20:17:04 UTC

Review Request 66149: OOZIE-2600 OYA: Update Documentation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66149/
-----------------------------------------------------------

Review request for oozie, Peter Cseh and Robert Kanter.


Repository: oozie-git


Description
-------

OOZIE-2600 OYA: Update Documentation


Diffs
-----

  docs/src/site/twiki/AG_Install.twiki 15042151f11666517f328f700cca022375bad8ae 
  docs/src/site/twiki/DG_DistCpActionExtension.twiki 260cd2578e7a4d78067512461fac72f47d32e7cb 
  docs/src/site/twiki/DG_Examples.twiki 87cac48bcb7bfb2c6628ad33429a036d0d2b676e 
  docs/src/site/twiki/DG_Hive2ActionExtension.twiki 094307fd81e57f51c25e6c6e30a2c7564a2bba76 
  docs/src/site/twiki/DG_HiveActionExtension.twiki a0d7b578ba0dd30fa8cd8c0b8a6c796c20e78c93 
  docs/src/site/twiki/DG_ShellActionExtension.twiki 493254a6f5d77eaa3dfa56ba39047e0847fa15ee 
  docs/src/site/twiki/DG_SparkActionExtension.twiki 294e7dd566b8849742e42962ce164c71b9caaed9 
  docs/src/site/twiki/DG_SqoopActionExtension.twiki 906ba5476f7628b3bf70dc3d6d5ef4a48418ea94 
  docs/src/site/twiki/DG_SshActionExtension.twiki c2e33c90c154df1e978e09c1534474a107191cd5 
  docs/src/site/twiki/ENG_MiniOozie.twiki 2c397264e1d758bae0c0590289d329a82fa3fd8c 
  docs/src/site/twiki/WorkflowFunctionalSpec.twiki 038c430d37887617070f2cb13dd0eba0962600d2 


Diff: https://reviews.apache.org/r/66149/diff/1/


Testing
-------

This is a documentation-only task, hence no testing except for generating the documentation, and checking, is done:
```
mvn clean install -DskipTests -Denforcer.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -PgenerateDocs
```


Thanks,

András Piros


Re: Review Request 66149: OOZIE-2600 OYA: Update Documentation

Posted by Peter Cseh via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66149/#review199654
-----------------------------------------------------------


Ship it!




Ship It!

- Peter Cseh


On March 20, 2018, 5:06 p.m., András Piros wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66149/
> -----------------------------------------------------------
> 
> (Updated March 20, 2018, 5:06 p.m.)
> 
> 
> Review request for oozie, Peter Cseh and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-2600 OYA: Update Documentation
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/AG_Install.twiki 15042151f11666517f328f700cca022375bad8ae 
>   docs/src/site/twiki/DG_DistCpActionExtension.twiki 260cd2578e7a4d78067512461fac72f47d32e7cb 
>   docs/src/site/twiki/DG_Examples.twiki 87cac48bcb7bfb2c6628ad33429a036d0d2b676e 
>   docs/src/site/twiki/DG_Hive2ActionExtension.twiki 094307fd81e57f51c25e6c6e30a2c7564a2bba76 
>   docs/src/site/twiki/DG_HiveActionExtension.twiki a0d7b578ba0dd30fa8cd8c0b8a6c796c20e78c93 
>   docs/src/site/twiki/DG_ShellActionExtension.twiki 493254a6f5d77eaa3dfa56ba39047e0847fa15ee 
>   docs/src/site/twiki/DG_SparkActionExtension.twiki 294e7dd566b8849742e42962ce164c71b9caaed9 
>   docs/src/site/twiki/DG_SqoopActionExtension.twiki 906ba5476f7628b3bf70dc3d6d5ef4a48418ea94 
>   docs/src/site/twiki/DG_SshActionExtension.twiki c2e33c90c154df1e978e09c1534474a107191cd5 
>   docs/src/site/twiki/ENG_MiniOozie.twiki 2c397264e1d758bae0c0590289d329a82fa3fd8c 
>   docs/src/site/twiki/WorkflowFunctionalSpec.twiki 038c430d37887617070f2cb13dd0eba0962600d2 
> 
> 
> Diff: https://reviews.apache.org/r/66149/diff/4/
> 
> 
> Testing
> -------
> 
> This is a documentation-only task, hence no testing except for generating the documentation, and checking, is done:
> ```
> mvn clean install -DskipTests -Denforcer.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -PgenerateDocs
> ```
> 
> 
> Thanks,
> 
> András Piros
> 
>


Re: Review Request 66149: OOZIE-2600 OYA: Update Documentation

Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66149/
-----------------------------------------------------------

(Updated March 20, 2018, 5:06 p.m.)


Review request for oozie, Peter Cseh and Robert Kanter.


Repository: oozie-git


Description
-------

OOZIE-2600 OYA: Update Documentation


Diffs (updated)
-----

  docs/src/site/twiki/AG_Install.twiki 15042151f11666517f328f700cca022375bad8ae 
  docs/src/site/twiki/DG_DistCpActionExtension.twiki 260cd2578e7a4d78067512461fac72f47d32e7cb 
  docs/src/site/twiki/DG_Examples.twiki 87cac48bcb7bfb2c6628ad33429a036d0d2b676e 
  docs/src/site/twiki/DG_Hive2ActionExtension.twiki 094307fd81e57f51c25e6c6e30a2c7564a2bba76 
  docs/src/site/twiki/DG_HiveActionExtension.twiki a0d7b578ba0dd30fa8cd8c0b8a6c796c20e78c93 
  docs/src/site/twiki/DG_ShellActionExtension.twiki 493254a6f5d77eaa3dfa56ba39047e0847fa15ee 
  docs/src/site/twiki/DG_SparkActionExtension.twiki 294e7dd566b8849742e42962ce164c71b9caaed9 
  docs/src/site/twiki/DG_SqoopActionExtension.twiki 906ba5476f7628b3bf70dc3d6d5ef4a48418ea94 
  docs/src/site/twiki/DG_SshActionExtension.twiki c2e33c90c154df1e978e09c1534474a107191cd5 
  docs/src/site/twiki/ENG_MiniOozie.twiki 2c397264e1d758bae0c0590289d329a82fa3fd8c 
  docs/src/site/twiki/WorkflowFunctionalSpec.twiki 038c430d37887617070f2cb13dd0eba0962600d2 


Diff: https://reviews.apache.org/r/66149/diff/4/

Changes: https://reviews.apache.org/r/66149/diff/3-4/


Testing
-------

This is a documentation-only task, hence no testing except for generating the documentation, and checking, is done:
```
mvn clean install -DskipTests -Denforcer.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -PgenerateDocs
```


Thanks,

András Piros


Re: Review Request 66149: OOZIE-2600 OYA: Update Documentation

Posted by Peter Cseh via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66149/#review199552
-----------------------------------------------------------




docs/src/site/twiki/WorkflowFunctionalSpec.twiki
Line 8 (original), 8 (patched)
<https://reviews.apache.org/r/66149/#comment279836>

    Please update the version here as well to 5.0


- Peter Cseh


On March 20, 2018, 2:48 p.m., András Piros wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66149/
> -----------------------------------------------------------
> 
> (Updated March 20, 2018, 2:48 p.m.)
> 
> 
> Review request for oozie, Peter Cseh and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-2600 OYA: Update Documentation
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/AG_Install.twiki 15042151f11666517f328f700cca022375bad8ae 
>   docs/src/site/twiki/DG_DistCpActionExtension.twiki 260cd2578e7a4d78067512461fac72f47d32e7cb 
>   docs/src/site/twiki/DG_Examples.twiki 87cac48bcb7bfb2c6628ad33429a036d0d2b676e 
>   docs/src/site/twiki/DG_Hive2ActionExtension.twiki 094307fd81e57f51c25e6c6e30a2c7564a2bba76 
>   docs/src/site/twiki/DG_HiveActionExtension.twiki a0d7b578ba0dd30fa8cd8c0b8a6c796c20e78c93 
>   docs/src/site/twiki/DG_ShellActionExtension.twiki 493254a6f5d77eaa3dfa56ba39047e0847fa15ee 
>   docs/src/site/twiki/DG_SparkActionExtension.twiki 294e7dd566b8849742e42962ce164c71b9caaed9 
>   docs/src/site/twiki/DG_SqoopActionExtension.twiki 906ba5476f7628b3bf70dc3d6d5ef4a48418ea94 
>   docs/src/site/twiki/DG_SshActionExtension.twiki c2e33c90c154df1e978e09c1534474a107191cd5 
>   docs/src/site/twiki/ENG_MiniOozie.twiki 2c397264e1d758bae0c0590289d329a82fa3fd8c 
>   docs/src/site/twiki/WorkflowFunctionalSpec.twiki 038c430d37887617070f2cb13dd0eba0962600d2 
> 
> 
> Diff: https://reviews.apache.org/r/66149/diff/3/
> 
> 
> Testing
> -------
> 
> This is a documentation-only task, hence no testing except for generating the documentation, and checking, is done:
> ```
> mvn clean install -DskipTests -Denforcer.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -PgenerateDocs
> ```
> 
> 
> Thanks,
> 
> András Piros
> 
>


Re: Review Request 66149: OOZIE-2600 OYA: Update Documentation

Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66149/
-----------------------------------------------------------

(Updated March 20, 2018, 2:48 p.m.)


Review request for oozie, Peter Cseh and Robert Kanter.


Repository: oozie-git


Description
-------

OOZIE-2600 OYA: Update Documentation


Diffs (updated)
-----

  docs/src/site/twiki/AG_Install.twiki 15042151f11666517f328f700cca022375bad8ae 
  docs/src/site/twiki/DG_DistCpActionExtension.twiki 260cd2578e7a4d78067512461fac72f47d32e7cb 
  docs/src/site/twiki/DG_Examples.twiki 87cac48bcb7bfb2c6628ad33429a036d0d2b676e 
  docs/src/site/twiki/DG_Hive2ActionExtension.twiki 094307fd81e57f51c25e6c6e30a2c7564a2bba76 
  docs/src/site/twiki/DG_HiveActionExtension.twiki a0d7b578ba0dd30fa8cd8c0b8a6c796c20e78c93 
  docs/src/site/twiki/DG_ShellActionExtension.twiki 493254a6f5d77eaa3dfa56ba39047e0847fa15ee 
  docs/src/site/twiki/DG_SparkActionExtension.twiki 294e7dd566b8849742e42962ce164c71b9caaed9 
  docs/src/site/twiki/DG_SqoopActionExtension.twiki 906ba5476f7628b3bf70dc3d6d5ef4a48418ea94 
  docs/src/site/twiki/DG_SshActionExtension.twiki c2e33c90c154df1e978e09c1534474a107191cd5 
  docs/src/site/twiki/ENG_MiniOozie.twiki 2c397264e1d758bae0c0590289d329a82fa3fd8c 
  docs/src/site/twiki/WorkflowFunctionalSpec.twiki 038c430d37887617070f2cb13dd0eba0962600d2 


Diff: https://reviews.apache.org/r/66149/diff/3/

Changes: https://reviews.apache.org/r/66149/diff/2-3/


Testing
-------

This is a documentation-only task, hence no testing except for generating the documentation, and checking, is done:
```
mvn clean install -DskipTests -Denforcer.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -PgenerateDocs
```


Thanks,

András Piros


Re: Review Request 66149: OOZIE-2600 OYA: Update Documentation

Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66149/
-----------------------------------------------------------

(Updated March 20, 2018, 11:35 a.m.)


Review request for oozie, Peter Cseh and Robert Kanter.


Changes
-------

Addressing review comments.


Repository: oozie-git


Description
-------

OOZIE-2600 OYA: Update Documentation


Diffs (updated)
-----

  docs/src/site/twiki/AG_Install.twiki 15042151f11666517f328f700cca022375bad8ae 
  docs/src/site/twiki/DG_DistCpActionExtension.twiki 260cd2578e7a4d78067512461fac72f47d32e7cb 
  docs/src/site/twiki/DG_Examples.twiki 87cac48bcb7bfb2c6628ad33429a036d0d2b676e 
  docs/src/site/twiki/DG_Hive2ActionExtension.twiki 094307fd81e57f51c25e6c6e30a2c7564a2bba76 
  docs/src/site/twiki/DG_HiveActionExtension.twiki a0d7b578ba0dd30fa8cd8c0b8a6c796c20e78c93 
  docs/src/site/twiki/DG_ShellActionExtension.twiki 493254a6f5d77eaa3dfa56ba39047e0847fa15ee 
  docs/src/site/twiki/DG_SparkActionExtension.twiki 294e7dd566b8849742e42962ce164c71b9caaed9 
  docs/src/site/twiki/DG_SqoopActionExtension.twiki 906ba5476f7628b3bf70dc3d6d5ef4a48418ea94 
  docs/src/site/twiki/DG_SshActionExtension.twiki c2e33c90c154df1e978e09c1534474a107191cd5 
  docs/src/site/twiki/ENG_MiniOozie.twiki 2c397264e1d758bae0c0590289d329a82fa3fd8c 
  docs/src/site/twiki/WorkflowFunctionalSpec.twiki 038c430d37887617070f2cb13dd0eba0962600d2 


Diff: https://reviews.apache.org/r/66149/diff/2/

Changes: https://reviews.apache.org/r/66149/diff/1-2/


Testing
-------

This is a documentation-only task, hence no testing except for generating the documentation, and checking, is done:
```
mvn clean install -DskipTests -Denforcer.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -PgenerateDocs
```


Thanks,

András Piros


Re: Review Request 66149: OOZIE-2600 OYA: Update Documentation

Posted by Peter Cseh via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66149/#review199531
-----------------------------------------------------------




docs/src/site/twiki/AG_Install.twiki
Lines 307 (patched)
<https://reviews.apache.org/r/66149/#comment279821>

    We should mention that it's on by default



docs/src/site/twiki/AG_Install.twiki
Lines 325-326 (patched)
<https://reviews.apache.org/r/66149/#comment279820>

    We should mention that the list can be extended in oozie-site.xml and there are examples for this in oozie-default.xml



docs/src/site/twiki/AG_Install.twiki
Lines 329 (patched)
<https://reviews.apache.org/r/66149/#comment279819>

    oozie.launcher.prepend, isn't it?
    Also, we should mention the default value


- Peter Cseh


On March 19, 2018, 8:17 p.m., András Piros wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66149/
> -----------------------------------------------------------
> 
> (Updated March 19, 2018, 8:17 p.m.)
> 
> 
> Review request for oozie, Peter Cseh and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-2600 OYA: Update Documentation
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/AG_Install.twiki 15042151f11666517f328f700cca022375bad8ae 
>   docs/src/site/twiki/DG_DistCpActionExtension.twiki 260cd2578e7a4d78067512461fac72f47d32e7cb 
>   docs/src/site/twiki/DG_Examples.twiki 87cac48bcb7bfb2c6628ad33429a036d0d2b676e 
>   docs/src/site/twiki/DG_Hive2ActionExtension.twiki 094307fd81e57f51c25e6c6e30a2c7564a2bba76 
>   docs/src/site/twiki/DG_HiveActionExtension.twiki a0d7b578ba0dd30fa8cd8c0b8a6c796c20e78c93 
>   docs/src/site/twiki/DG_ShellActionExtension.twiki 493254a6f5d77eaa3dfa56ba39047e0847fa15ee 
>   docs/src/site/twiki/DG_SparkActionExtension.twiki 294e7dd566b8849742e42962ce164c71b9caaed9 
>   docs/src/site/twiki/DG_SqoopActionExtension.twiki 906ba5476f7628b3bf70dc3d6d5ef4a48418ea94 
>   docs/src/site/twiki/DG_SshActionExtension.twiki c2e33c90c154df1e978e09c1534474a107191cd5 
>   docs/src/site/twiki/ENG_MiniOozie.twiki 2c397264e1d758bae0c0590289d329a82fa3fd8c 
>   docs/src/site/twiki/WorkflowFunctionalSpec.twiki 038c430d37887617070f2cb13dd0eba0962600d2 
> 
> 
> Diff: https://reviews.apache.org/r/66149/diff/1/
> 
> 
> Testing
> -------
> 
> This is a documentation-only task, hence no testing except for generating the documentation, and checking, is done:
> ```
> mvn clean install -DskipTests -Denforcer.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -PgenerateDocs
> ```
> 
> 
> Thanks,
> 
> András Piros
> 
>