[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #602: Fixes an issue that could not search on zone select

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#discussion_r474663565



##########
File path: src/views/image/RegisterOrUploadIso.vue
##########
@@ -90,14 +90,7 @@
             :loading="zoneLoading"
             :placeholder="apiParams.zoneid.description">
             <a-select-option :value="opt.id" v-for="opt in zones" :key="opt.id">
-              <div v-if="currentForm === 'Upload'">
-                <div v-if="opt.name !== $t('label.all.zone')">
-                  {{ opt.name || opt.description }}
-                </div>
-              </div>
-              <div v-else>
-                {{ opt.name || opt.description }}
-              </div>
+              {{ opt.name || opt.description }}

Review comment:
       @utchoang @davidjumani have you tested the case that when uploading, all zones are not shown; but when registering by URL then all zones option is shown.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org