[GitHub] [solr] anshumg commented on a diff in pull request #1312: SOLR-16635: Resolve crypto keys file path in MiniSolrCloudCluster

["anshumg (via GitHub)" <gi...@apache.org>]

anshumg commented on code in PR #1312:
URL: https://github.com/apache/solr/pull/1312#discussion_r1089321537


##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -89,6 +90,10 @@
 public class MiniSolrCloudCluster {
 
   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+  private static final URL PRE_GENERATED_PRIVATE_K_URL =
+      MiniSolrCloudCluster.class.getClassLoader().getResource("cryptokeys/priv_key512_pkcs8.pem");
+  private static final URL PRE_GENERATED_PUBLIC_K_URL =

Review Comment:
   Same here



##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -89,6 +90,10 @@
 public class MiniSolrCloudCluster {
 
   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+  private static final URL PRE_GENERATED_PRIVATE_K_URL =

Review Comment:
   nit-pick, but can we use `KEY` instead of `K` i.e. `PRE_GENERATED_PRIVATE_KEY_URL`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org