You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by kwmonroe <gi...@git.apache.org> on 2016/05/10 01:34:49 UTC
[GitHub] bigtop pull request: Adding Juju charms and bundles to the Bigtop ...
GitHub user kwmonroe opened a pull request:
https://github.com/apache/bigtop/pull/108
Adding Juju charms and bundles to the Bigtop repo
Initial PR to include Juju charms and bundles in the Bigtop repo. See the "Bigtop and Juju" note to the dev list on May 9 for more detail and discussion.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juju-solutions/bigtop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit a18143ed615f77973895827979d6ea82c8772fba
Author: Kevin W Monroe <ke...@canonical.com>
Date: 2016-05-09T23:05:57Z
add juju charm/bundle source
- add new hierarchy to house juju charm / bundle source
- commit core bigtop charms and reference bundle to the hierarchy
commit 0101d44d273f41b3610aa7b2ae38eb64e61f2348
Author: Kevin W Monroe <ke...@canonical.com>
Date: 2016-05-09T23:53:18Z
charm revno bump to set reverse_dns_bad before /etc/hosts adjustments if needed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #108: BIGTOP-2435 Add Juju charms for hadoop component
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe closed the pull request at:
https://github.com/apache/bigtop/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #108: BIGTOP-2435 Add Juju charms for hadoop component
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/108
Thanks for getting out of the way to address the community feedback, guys.
I believe in this shape, the patch stands to be as small as it possibly can be. I don't really have anything to say about it, so I will just go ahead and commit it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2435 Add Juju charm, bundle, and testplan source...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the pull request:
https://github.com/apache/bigtop/pull/108
I have reviewed the [dev@ thread discussion](https://lists.apache.org/thread.html/Z2uoq25segpbsm6) on this issue and while I agree with Olaf, that commit is a bit on the large side, it seems to be doing all the correct things. I believe the directory layout also makes sense. And the patch is passes the RAT too.
It might makes sense to add weather-report part separately, but after all it is just one tiny file and a README in there, so it doesn't make that much difference.
The only real comment I can make is about 2 vs 4 spaces of the indentation as we are using the former. However, the majority of the new code is Python, so I am not really sure if 2-spaces indents look good (or even are acceptable) in that language.
Hence, I am all +1 on getting this committed, unless there are hard objections from the rest of the community?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: Adding Juju charms and bundles to the Bigtop ...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the pull request:
https://github.com/apache/bigtop/pull/108#issuecomment-218072555
Thanks for your plans of contributing the deployment code back into Apache Bigtop! Could you please open a JIRA ticket in https://issues.apache.org/jira/browse/BIGTOP (I will add you as a contributor so the ticket can be assigned to you) and make the commit comment in the form of
`BIGTOP-####. JIRA synopsis`
It is minor stuff, but helps us to keep the patches uniformed. I will start reviewing your patch tomorrow, so expect more comments soon ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2435 Add Juju charm, bundle, and testplan source...
Posted by johnsca <gi...@git.apache.org>.
Github user johnsca commented on the pull request:
https://github.com/apache/bigtop/pull/108
4 spaces is standard for Python code (it is strongly recommended in PEP-8, the official code style guideline for Python), and Python linters will complain if you use something else without adding explicit overrides. If you don't feel strongly about the consistency, I'd recommend keeping 4 spaces for the Python code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2435 Add Juju charm, bundle, and testp...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the pull request:
https://github.com/apache/bigtop/pull/108#issuecomment-220157012
Let's see if now it gets linked to the JIRA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #108: BIGTOP-2435 Add Juju charms for hadoop component
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/108
Thanks c0s! https://github.com/apache/bigtop/commit/d639645e7726577e5898f5da3722c6be65b2c9bd has the goods. Closing this out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #108: BIGTOP-2435 Add Juju charm, bundle, and testplan sources
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/108
In an effort to reduce the size of this request, I have pulled out the Juju bundles (bigtop-deploy/juju) and Cloud Weather Report (bigtop-tests/cloud-weather-report). This just leaves the core set of hadoop charms up for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #108: BIGTOP-2435 Add Juju charms for hadoop component
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/108
Committed and pushed to the Apache tree. Please feel free to close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---