You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/29 21:10:20 UTC

[GitHub] [spark] zero323 opened a new pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

zero323 opened a new pull request #29905:
URL: https://github.com/apache/spark/pull/29905


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   Adds `nth_value` function to SparkR.
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   Feature parity. The function has been already added to [Scala](https://issues.apache.org/jira/browse/SPARK-27951) and [Python](https://issues.apache.org/jira/browse/SPARK-33020).
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   Yes. New function is exposed to R users.
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   New unit tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701010243






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498583184



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+#' @details
+#' \code{nth_value}: Window function: returns the value that is the \code{offset}th
+#' row of the window frame# (counting from 1), and \code{null} if the size of window
+#' frame is less than \code{offset} rows.
+#'
+#' @param offset a numeric indicating number of row to use as the value
+#' @param na.rm a logical which indicates that the Nth value should skip null in the
+#'        determination of which row to use
+#'
+#' @rdname column_window_functions
+#' @aliases nth_value nth_value,characterOrColumn-method
+#' @examples
+#' \dontrun{
+#' nth_value(df$mpg, 3)
+#' nth_value(df$mpg, 3, TRUE)
+#' }

Review comment:
       It seems that we have a different place to put the example. Please see the following.
   - https://spark.apache.org/docs/latest/api/R/column_window_functions.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702601291


   **[Test build #129342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129342/testReport)** for PR 29905 at commit [`60fb442`](https://github.com/apache/spark/commit/60fb4427345c4bd216f3163dc9b6ee20039d5d15).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701410403


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33892/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702272676






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702368022


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33931/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702272676






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701022215


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33869/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-700993104


   **[Test build #129252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129252/testReport)** for PR 29905 at commit [`8251e61`](https://github.com/apache/spark/commit/8251e61ad294ceed5ce2ebbce629831a5f2dc320).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

zero323 commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498405569



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+          #' @details

Review comment:
       🤦




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701422500


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33892/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702256448






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701021846


   **[Test build #129255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129255/testReport)** for PR 29905 at commit [`40d3757`](https://github.com/apache/spark/commit/40d375768c8c94e40b13052beb40ddfd5102cbec).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701422535






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702262805


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33923/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701032603


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33872/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702379588


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33931/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701040840






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701383131


   **[Test build #129275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129275/testReport)** for PR 29905 at commit [`c5f2661`](https://github.com/apache/spark/commit/c5f266181c8cc4794d89cb7660eba5d3ad182ab5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498475635



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+  #' @details

Review comment:
       Got it. Never mind~ I was just wondering the type of editor, @zero323 . :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r497942351



##########
File path: R/pkg/R/functions.R
##########
@@ -4426,3 +4426,39 @@ setMethod("timestamp_seconds",
         )
         column(jc)
     })
+
+#' @details

Review comment:
       Hi, @zero323 .
   Please move this into to `Window functions` group.
   - https://github.com/apache/spark/blob/master/R/pkg/R/functions.R#L3215




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701010243


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702256448






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-700993104


   **[Test build #129252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129252/testReport)** for PR 29905 at commit [`8251e61`](https://github.com/apache/spark/commit/8251e61ad294ceed5ce2ebbce629831a5f2dc320).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701010188


   **[Test build #129252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129252/testReport)** for PR 29905 at commit [`8251e61`](https://github.com/apache/spark/commit/8251e61ad294ceed5ce2ebbce629831a5f2dc320).
    * This patch **fails SparkR unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701021846


   **[Test build #129255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129255/testReport)** for PR 29905 at commit [`40d3757`](https://github.com/apache/spark/commit/40d375768c8c94e40b13052beb40ddfd5102cbec).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701032916


   **[Test build #129255 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129255/testReport)** for PR 29905 at commit [`40d3757`](https://github.com/apache/spark/commit/40d375768c8c94e40b13052beb40ddfd5102cbec).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701405842






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702599959


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33953/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701904523


   **[Test build #129303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129303/testReport)** for PR 29905 at commit [`431f91a`](https://github.com/apache/spark/commit/431f91a5e1b4d90a4e15733caebccfbb8b789b62).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701040840






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498340313



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+          #' @details

Review comment:
       Indentation is broken here, @zero323 . Please see line 3277.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702365053






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498453573



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+  #' @details

Review comment:
       @zero323 . It's weird. Which editor are you using now? This is still wrong. You should not put a leading space here. This line still have 2-spaces at the beginning




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701930974






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702347222


   **[Test build #129316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129316/testReport)** for PR 29905 at commit [`43503eb`](https://github.com/apache/spark/commit/43503ebcd75de25d05f52f22bad4461c15f698b8).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702581241


   **[Test build #129342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129342/testReport)** for PR 29905 at commit [`60fb442`](https://github.com/apache/spark/commit/60fb4427345c4bd216f3163dc9b6ee20039d5d15).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702272655


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33923/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701405650


   **[Test build #129275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129275/testReport)** for PR 29905 at commit [`c5f2661`](https://github.com/apache/spark/commit/c5f266181c8cc4794d89cb7660eba5d3ad182ab5).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498582542



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+#' @details
+#' \code{nth_value}: Window function: returns the value that is the \code{offset}th
+#' row of the window frame# (counting from 1), and \code{null} if the size of window
+#' frame is less than \code{offset} rows.
+#'
+#' @param offset a numeric indicating number of row to use as the value
+#' @param na.rm a logical which indicates that the Nth value should skip null in the
+#'        determination of which row to use
+#'
+#' @rdname column_window_functions
+#' @aliases nth_value nth_value,characterOrColumn-method
+#' @examples
+#' \dontrun{
+#' nth_value(df$mpg, 3)
+#' nth_value(df$mpg, 3, TRUE)
+#' }

Review comment:
       Shall we remove this examples because this is insufficient in any way? And, for me, it seems that all the other `column_window_functions` around here also doesn't provide example because it's difficult to give a reproducible short example here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701014591


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33869/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701930974






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498582542



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+#' @details
+#' \code{nth_value}: Window function: returns the value that is the \code{offset}th
+#' row of the window frame# (counting from 1), and \code{null} if the size of window
+#' frame is less than \code{offset} rows.
+#'
+#' @param offset a numeric indicating number of row to use as the value
+#' @param na.rm a logical which indicates that the Nth value should skip null in the
+#'        determination of which row to use
+#'
+#' @rdname column_window_functions
+#' @aliases nth_value nth_value,characterOrColumn-method
+#' @examples
+#' \dontrun{
+#' nth_value(df$mpg, 3)
+#' nth_value(df$mpg, 3, TRUE)
+#' }

Review comment:
       Shall we remove this examples because this is insufficient in any way? And, for me, it seems that all the other `column_window_functions` also doesn't provide example because it's difficult to give a reproducible short example here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702379611






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701920745






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702599987






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701033037






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

zero323 commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498646041



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+#' @details
+#' \code{nth_value}: Window function: returns the value that is the \code{offset}th
+#' row of the window frame# (counting from 1), and \code{null} if the size of window
+#' frame is less than \code{offset} rows.
+#'
+#' @param offset a numeric indicating number of row to use as the value
+#' @param na.rm a logical which indicates that the Nth value should skip null in the
+#'        determination of which row to use
+#'
+#' @rdname column_window_functions
+#' @aliases nth_value nth_value,characterOrColumn-method
+#' @examples
+#' \dontrun{
+#' nth_value(df$mpg, 3)
+#' nth_value(df$mpg, 3, TRUE)
+#' }

Review comment:
       > It seems that we have a different place to put the example. Please see the following.
   > 
   > * https://spark.apache.org/docs/latest/api/R/column_window_functions.html
   
   We are actually pretty inconsistent about. At the end of the day all examples for the same `rdname` are placed in the sample example block, so it doesn't make much difference in practice. The biggest advantage of having "top-level" `examples` is that we can avoid redefinition of auxiliary objects. 
   
   But having examples few KLOCs from actual code is not great. One possible approach would be to split functions by family. Anyway, just thinking out loud.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701405842






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701010247


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129252/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

zero323 commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702607363


   Thank you @dongjoon-hyun


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701922940


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33918/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701422535






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498583382



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+#' @details
+#' \code{nth_value}: Window function: returns the value that is the \code{offset}th
+#' row of the window frame# (counting from 1), and \code{null} if the size of window
+#' frame is less than \code{offset} rows.
+#'
+#' @param offset a numeric indicating number of row to use as the value
+#' @param na.rm a logical which indicates that the Nth value should skip null in the
+#'        determination of which row to use
+#'
+#' @rdname column_window_functions
+#' @aliases nth_value nth_value,characterOrColumn-method
+#' @examples
+#' \dontrun{
+#' nth_value(df$mpg, 3)
+#' nth_value(df$mpg, 3, TRUE)
+#' }

Review comment:
       Please put `nth_value` around https://github.com/apache/spark/blame/master/R/pkg/R/functions.R#L341 .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702593004


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33953/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702379611






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

zero323 commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498229387



##########
File path: R/pkg/R/functions.R
##########
@@ -4426,3 +4426,39 @@ setMethod("timestamp_seconds",
         )
         column(jc)
     })
+
+#' @details

Review comment:
       Thanks for the review @dongjoon-hyun. Adjusted.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zero323 commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

zero323 commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498461400



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+  #' @details

Review comment:
       Remote Atom with somewhat hacky Teletype setup, and it is not like it's R support is great in the first place.
   
   But I should double check this, instead of trusting the thing. Sorry for the mess.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498583382



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+#' @details
+#' \code{nth_value}: Window function: returns the value that is the \code{offset}th
+#' row of the window frame# (counting from 1), and \code{null} if the size of window
+#' frame is less than \code{offset} rows.
+#'
+#' @param offset a numeric indicating number of row to use as the value
+#' @param na.rm a logical which indicates that the Nth value should skip null in the
+#'        determination of which row to use
+#'
+#' @rdname column_window_functions
+#' @aliases nth_value nth_value,characterOrColumn-method
+#' @examples
+#' \dontrun{
+#' nth_value(df$mpg, 3)
+#' nth_value(df$mpg, 3, TRUE)
+#' }

Review comment:
       Could you search that place and put `nth_value` there?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702234887


   **[Test build #129308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129308/testReport)** for PR 29905 at commit [`1a0d598`](https://github.com/apache/spark/commit/1a0d598174bd0bfa216c033668cd9f6fa59b1a53).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701930943


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33918/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701920504


   **[Test build #129303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129303/testReport)** for PR 29905 at commit [`431f91a`](https://github.com/apache/spark/commit/431f91a5e1b4d90a4e15733caebccfbb8b789b62).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701040822


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33872/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702601472






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702347222


   **[Test build #129316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129316/testReport)** for PR 29905 at commit [`43503eb`](https://github.com/apache/spark/commit/43503ebcd75de25d05f52f22bad4461c15f698b8).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702256262


   **[Test build #129308 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129308/testReport)** for PR 29905 at commit [`1a0d598`](https://github.com/apache/spark/commit/1a0d598174bd0bfa216c033668cd9f6fa59b1a53).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498340313



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+          #' @details

Review comment:
       Indentation is broken here, @zero323 .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702583266


   Merged to master for Apache Spark 3.1.0 on December 2020.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702234887


   **[Test build #129308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129308/testReport)** for PR 29905 at commit [`1a0d598`](https://github.com/apache/spark/commit/1a0d598174bd0bfa216c033668cd9f6fa59b1a53).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701033037






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701904523


   **[Test build #129303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129303/testReport)** for PR 29905 at commit [`431f91a`](https://github.com/apache/spark/commit/431f91a5e1b4d90a4e15733caebccfbb8b789b62).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701920745






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701383131


   **[Test build #129275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129275/testReport)** for PR 29905 at commit [`c5f2661`](https://github.com/apache/spark/commit/c5f266181c8cc4794d89cb7660eba5d3ad182ab5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702581241


   **[Test build #129342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129342/testReport)** for PR 29905 at commit [`60fb442`](https://github.com/apache/spark/commit/60fb4427345c4bd216f3163dc9b6ee20039d5d15).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702365053






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701022224






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R][SQL] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-701022224






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins removed a comment on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702601472






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun commented on a change in pull request #29905:
URL: https://github.com/apache/spark/pull/29905#discussion_r498582542



##########
File path: R/pkg/R/functions.R
##########
@@ -3298,6 +3298,42 @@ setMethod("lead",
             column(jc)
           })
 
+#' @details
+#' \code{nth_value}: Window function: returns the value that is the \code{offset}th
+#' row of the window frame# (counting from 1), and \code{null} if the size of window
+#' frame is less than \code{offset} rows.
+#'
+#' @param offset a numeric indicating number of row to use as the value
+#' @param na.rm a logical which indicates that the Nth value should skip null in the
+#'        determination of which row to use
+#'
+#' @rdname column_window_functions
+#' @aliases nth_value nth_value,characterOrColumn-method
+#' @examples
+#' \dontrun{
+#' nth_value(df$mpg, 3)
+#' nth_value(df$mpg, 3, TRUE)
+#' }

Review comment:
       Shall we remove this examples because this is insufficient in any way? And, for me, it seems that the other `column_window_functions` also doesn't provide example because it's difficult to give a reproducible short example here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

SparkQA commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702364894


   **[Test build #129316 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129316/testReport)** for PR 29905 at commit [`43503eb`](https://github.com/apache/spark/commit/43503ebcd75de25d05f52f22bad4461c15f698b8).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

AmplabJenkins commented on pull request #29905:
URL: https://github.com/apache/spark/pull/29905#issuecomment-702599987






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #29905: [SPARK-33030][R] Add nth_value to SparkR

Posted by GitBox <gi...@apache.org>.

dongjoon-hyun closed pull request #29905:
URL: https://github.com/apache/spark/pull/29905


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org