You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/03/31 15:39:45 UTC

[Impala-ASF-CR] IMPALA-10624: TestIcebergTable::test alter iceberg tables failed by stale file format

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17248


Change subject: IMPALA-10624: TestIcebergTable::test_alter_iceberg_tables failed by stale file format
......................................................................

IMPALA-10624: TestIcebergTable::test_alter_iceberg_tables failed by stale file format

During table creation we pushed all the table properties to the
Iceberg table, e.g. 'iceberg.file_format'. This works well with
current Iceberg version, but causes bugs with newer versions.

Newer versions of Iceberg refresh the HMS properties from the
table properties for every table update. That means if we
intially set a table property, we cannot modify it later because
Iceberg will rewrite it with the old value on every table update.

These table properties are not needed at the Iceberg table level,
so we can just skip passing them during table creation.

Testing:
 * ran existing tests
 * ran tests with newer version Iceberg
 * checked manually that we don't set these properties at the Iceberg
   table level

Change-Id: Iff8d5d1d90444aba11d47cfce522aaa45a4a74cc
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
2 files changed, 31 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/17248/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff8d5d1d90444aba11d47cfce522aaa45a4a74cc
Gerrit-Change-Number: 17248
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10624: TestIcebergTable::test alter iceberg tables failed by stale file format

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.

Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17248 )

Change subject: IMPALA-10624: TestIcebergTable::test_alter_iceberg_tables failed by stale file format
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17248/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/17248/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@177
PS1, Line 177: uld only 
> Thanks, I've added your version.
Thanks



-- 
To view, visit http://gerrit.cloudera.org:8080/17248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff8d5d1d90444aba11d47cfce522aaa45a4a74cc
Gerrit-Change-Number: 17248
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 17:45:41 +0000
Gerrit-HasComments: Yes