You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ndimiduk (via GitHub)" <gi...@apache.org> on 2023/06/21 15:09:23 UTC
[GitHub] [hbase-kustomize] ndimiduk opened a new pull request, #5: HBASE-27943 Rework kuttl image as a yetus precommit base
ndimiduk opened a new pull request, #5:
URL: https://github.com/apache/hbase-kustomize/pull/5
Here's a draft PR that demonstrates the direction this plan leads. Maybe we can bring the image build back to Apache Jenkins because there is some action on INFRA-24704. I'm not sure whether I prefer that vs. using GitHub actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-kustomize] aw-was-here commented on a diff in pull request #5: HBASE-27943 Rework kuttl image as a yetus precommit base
Posted by "aw-was-here (via GitHub)" <gi...@apache.org>.
aw-was-here commented on code in PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#discussion_r1240573639
##########
dev-support/jenkins/jenkins_precommit_github_yetus.sh:
##########
@@ -54,23 +51,33 @@ if [ ${missing_env} -gt 0 ]; then
exit 1
fi
-# TODO (HBASE-23900): cannot assume test-patch runs directly from sources
-TESTPATCHBIN="${YETUSDIR}/precommit/src/main/shell/test-patch.sh"
+declare -a DOCKER_ARGS
+DOCKER_ARGS+=('container' 'run')
+DOCKER_ARGS+=('--entrypoint' '/bin/bash')
+DOCKER_ARGS+=('--mount' "type=bind,source=$(pwd),target=/workdir")
+DOCKER_ARGS+=('--platform' 'linux/amd64')
+DOCKER_ARGS+=('--pull' 'always')
+DOCKER_ARGS+=('--quiet')
+DOCKER_ARGS+=('--rm')
+DOCKER_ARGS+=('--workdir' '/workdir')
+
+# path to test-patch in the container image
+TESTPATCHBIN="/usr/bin/test-patch.sh"
Review Comment:
In the container image, exec should be /usr/bin/test-patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-kustomize] aw-was-here commented on a diff in pull request #5: HBASE-27943 Rework kuttl image as a yetus precommit base
Posted by "aw-was-here (via GitHub)" <gi...@apache.org>.
aw-was-here commented on code in PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#discussion_r1240568368
##########
dockerfiles/kuttl/Dockerfile:
##########
@@ -18,15 +18,17 @@
# hadolint global ignore=DL3020
-ARG IMG_BASE='golang'
-ARG IMG_BASE_TAG='1.19-alpine'
+ARG IMG_BASE='ghcr.io/apache/yetus'
+ARG IMG_BASE_TAG='0.14.1'
ARG BASE_IMG_ALPINE='alpine'
ARG BASE_IMG_TAG_ALPINE='latest'
ARG YQ_IMG='mikefarah/yq'
ARG YQ_IMG_TAG='latest'
FROM ${BASE_IMG_ALPINE}:${BASE_IMG_TAG_ALPINE} as alpine
-RUN apk add --no-cache bash~=5
+RUN apk add --no-cache \
Review Comment:
yetus image is ubuntu...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27943 Rework kuttl image as a yetus precommit base [hbase-kustomize]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#issuecomment-1801572170
Thank you @aw-was-here !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27943 Rework kuttl image as a yetus precommit base [hbase-kustomize]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#issuecomment-1810255051
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ main Compile Tests _ |
| -0 :warning: | patch | 0m 1s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | codespell | 0m 0s | | No new issues. |
| +1 :green_heart: | detsecrets | 0m 2s | | No new issues. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | hadolint | 0m 0s | | No new issues. |
| +1 :green_heart: | markdownlint | 0m 0s | | No new issues. |
| -1 :x: | shellcheck | 0m 0s | [/results-shellcheck.txt](/results-shellcheck.txt) | The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | shelldocs | 0m 0s | | No new issues. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 0s | | The patch does not generate ASF License warnings. |
| | | 0m 7s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-kustomize/pull/5 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs hadolint markdownlint |
| uname | Linux 05df91fab26b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| Personality | /workdir/src/.yetus/personality.sh |
| git revision | main / 80b484246b03f29669df626749da4c7f2930719c |
| modules | C: . U: . |
| versions | git=2.25.1 codespell=2.2.1 detsecrets=1.2.0 markdownlint=0.31.1 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-kustomize] ndimiduk commented on a diff in pull request #5: HBASE-27943 Rework kuttl image as a yetus precommit base
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on code in PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#discussion_r1241831769
##########
dockerfiles/kuttl/Dockerfile:
##########
@@ -134,27 +155,38 @@ COPY --from=yq /usr/bin/yq /usr/bin/yq
COPY --from=kubectl /tmp/kubectl /usr/local/bin/
COPY --from=kuttl /tmp/kubectl-kuttl /usr/local/bin/
COPY --from=kustomize /tmp/kustomize /usr/local/bin/
-COPY dockerfiles/kuttl/entrypoint.sh /bin/
+COPY --chmod=0755 dockerfiles/kuttl/entrypoint.sh /bin/
+COPY --from=hadolint /bin/hadolint /bin/hadolint
Review Comment:
Hmm good point. All the golang apps should statically linked (I believe, that's go default), but I don't know for certain. Let me add some basic tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-kustomize] aw-was-here commented on a diff in pull request #5: HBASE-27943 Rework kuttl image as a yetus precommit base
Posted by "aw-was-here (via GitHub)" <gi...@apache.org>.
aw-was-here commented on code in PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#discussion_r1240568926
##########
dockerfiles/kuttl/Dockerfile:
##########
@@ -134,27 +155,38 @@ COPY --from=yq /usr/bin/yq /usr/bin/yq
COPY --from=kubectl /tmp/kubectl /usr/local/bin/
COPY --from=kuttl /tmp/kubectl-kuttl /usr/local/bin/
COPY --from=kustomize /tmp/kustomize /usr/local/bin/
-COPY dockerfiles/kuttl/entrypoint.sh /bin/
+COPY --chmod=0755 dockerfiles/kuttl/entrypoint.sh /bin/
+COPY --from=hadolint /bin/hadolint /bin/hadolint
Review Comment:
Unless these bits are statically linked, you may end up having some problems here because Alpine typically uses musl as its libc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27943 Rework kuttl image as a yetus precommit base [hbase-kustomize]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#issuecomment-1859714487
Thanks @Apache9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27943 Rework kuttl image as a yetus precommit base [hbase-kustomize]
Posted by "aw-was-here (via GitHub)" <gi...@apache.org>.
aw-was-here commented on PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#issuecomment-1786334177
> @aw-was-here @busbey any idea why the docker image that i build in one stage is not visible to the next?
`DOCKER_ARGS+=('--pull' 'always')` will ignore the local cache IIRC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27943 Rework kuttl image as a yetus precommit base [hbase-kustomize]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#issuecomment-1858837710
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ main Compile Tests _ |
| -0 :warning: | patch | 0m 0s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | codespell | 0m 0s | | No new issues. |
| +1 :green_heart: | detsecrets | 0m 2s | | No new issues. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | hadolint | 0m 0s | | No new issues. |
| +1 :green_heart: | markdownlint | 0m 1s | | No new issues. |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | shelldocs | 0m 0s | | No new issues. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 1s | | The patch does not generate ASF License warnings. |
| | | 0m 9s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-kustomize/pull/5 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs hadolint markdownlint |
| uname | Linux 37c5cca7a83d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| Personality | /workdir/src/.yetus/personality.sh |
| git revision | main / f54044e8b561d68664d7d3fed07e184d514960c1 |
| modules | C: . U: . |
| versions | git=2.25.1 codespell=2.2.1 detsecrets=1.2.0 markdownlint=0.31.1 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27943 Rework kuttl image as a yetus precommit base [hbase-kustomize]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#issuecomment-1858851480
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ main Compile Tests _ |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | codespell | 0m 0s | | No new issues. |
| +1 :green_heart: | detsecrets | 0m 2s | | No new issues. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | hadolint | 0m 0s | | No new issues. |
| +1 :green_heart: | markdownlint | 0m 2s | | No new issues. |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | shelldocs | 0m 0s | | No new issues. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 1s | | The patch does not generate ASF License warnings. |
| | | 0m 9s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-kustomize/pull/5 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs hadolint markdownlint |
| uname | Linux 8777e688f4bf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| Personality | /workdir/src/.yetus/personality.sh |
| git revision | main / daa11d3a9a00c94463cc9aef2cf6371497e5d3ad |
| modules | C: . U: . |
| versions | git=2.25.1 codespell=2.2.1 detsecrets=1.2.0 markdownlint=0.31.1 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27943 Rework kuttl image as a yetus precommit base [hbase-kustomize]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#issuecomment-1810206813
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ main Compile Tests _ |
| -0 :warning: | patch | 0m 1s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | codespell | 0m 1s | | No new issues. |
| +1 :green_heart: | detsecrets | 0m 1s | | No new issues. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | hadolint | 0m 0s | | No new issues. |
| +1 :green_heart: | markdownlint | 0m 1s | | No new issues. |
| -1 :x: | shellcheck | 0m 0s | [/results-shellcheck.txt](/results-shellcheck.txt) | The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | shelldocs | 0m 1s | | No new issues. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 0s | | The patch does not generate ASF License warnings. |
| | | 0m 6s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-kustomize/pull/5 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs hadolint markdownlint |
| uname | Linux 6b138ccc070a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| Personality | /workdir/src/.yetus/personality.sh |
| git revision | main / 80b484246b03f29669df626749da4c7f2930719c |
| modules | C: . U: . |
| versions | git=2.25.1 codespell=2.2.1 detsecrets=1.2.0 markdownlint=0.31.1 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27943 Rework kuttl image as a yetus precommit base [hbase-kustomize]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5#issuecomment-1777705321
@aw-was-here @busbey any idea why the docker image that i build in one stage is not visible to the next? See https://ci-hbase.apache.org/blue/organizations/jenkins/hbase-kustomize-github-pr/detail/PR-5/8/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27943 Rework kuttl image as a yetus precommit base [hbase-kustomize]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk merged PR #5:
URL: https://github.com/apache/hbase-kustomize/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org