You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/08/23 09:55:28 UTC
[Bug 120677] New: There is always one sd::framework::FrameworkHelper
object object not released when open a sd document
https://issues.apache.org/ooo/show_bug.cgi?id=120677
Priority: P3
Bug ID: 120677
Assignee: ooo-issues@incubator.apache.org
Summary: There is always one sd::framework::FrameworkHelper
object object not released when open a sd document
Severity: normal
Issue Type: DEFECT
Classification: Application
OS: All
Reporter: zhangjf@apache.org
Hardware: All
Status: CONFIRMED
Version: AOO350-dev
Component: code
Product: presentation
When opening a sd document, it creates a FrameworkHelper for each viewshell in
api FrameworkHelper::Instance(), but it always not released when closing
documents.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120677] There is always one sd::framework::FrameworkHelper
object object not released when open a sd document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120677
--- Comment #2 from SVN Robot <sv...@dev.null.org> ---
"zhangjf" committed SVN revision 1380959 into trunk:
#i120677#, prevent putting non singleton object FrameworkHelper into
SdGlobal...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120677] There is always one sd::framework::FrameworkHelper
object object not released when open a sd document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120677
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|ooo-issues@incubator.apache |zhangjf@apache.org
|.org |
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120677] There is always one sd::framework::FrameworkHelper
object object not released when open a sd document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120677
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from zhang jianfang <zh...@apache.org> ---
Change to resolved state
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120677] There is always one sd::framework::FrameworkHelper
object object not released when open a sd document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120677
zhang jianfang <zh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79089| |review?
Flags| |
--- Comment #1 from zhang jianfang <zh...@apache.org> ---
Created attachment 79089
--> https://issues.apache.org/ooo/attachment.cgi?id=79089&action=edit
sd.FrameworkHelper.cxx.patch
SdGlobalResourceContainer is designed for controling the lifetime of some
singleton objects (See comments in file sd\inc\sdmod.hxx). But FrameworkHelper
is not a singleton object, for each document/shell, it creates one object (see
sd::ViewShellBase::GetMainViewShell() api). It is meaningless to put the
created FrameworkHelper object into SdGlobalResourceContainer but memory leak.
FrameworkHelper class keeps it's own static maInstanceMap list to keep the
created objects, when an object are safe to be destroyed, it is removed from
maInstanceMap list in API FrameworkHelper::ReleaseInstance().
So it is safe not to to put the created FrameworkHelper object into
SdGlobalResourceContainer.
--
You are receiving this mail because:
You are the assignee for the bug.