[GitHub] matthiasblaesing commented on issue #454: [NETBEANS-461] providing ZIP file with extbrowser DLLs during build

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #454: [NETBEANS-461] providing ZIP file with extbrowser DLLs during build
URL: https://github.com/apache/incubator-netbeans/pull/454#issuecomment-373155655
 
 
   @geertjanw thanks for looking into this - I assume the files were build from the sources contained in the `native` subdirectory of extbrowser? This currently breaks builds, because the Verification task fails:
   
   ```
   /home/travis/build/apache/incubator-netbeans/nbbuild/build.xml:1532: Failed VerifyLibsAndLicenses test(s):
   Some license files have incorrect headers
   extbrowser/external/extbrowser-dlls.zip does not appear to include a version number
   extbrowser/external/extbrowser-dlls.zip is not associated with any license file
   ```
   
   I suggest to rename the zip to something like `extbrowser-dlls-<year><month><day>.zip` to satisfy the "requires version" requirement. For the "license file requirement" a file `extbrowser-dlls-<year><month><day>-license.txt` is required. Assuming the files were build from the CDDL sources, `lib.profiler/external/profiler-external-binaries-8.2-license.txt` can be used as a template.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists