You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2016/12/20 20:52:36 UTC

Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54911/
-----------------------------------------------------------

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-19206
    https://issues.apache.org/jira/browse/AMBARI-19206


Repository: ambari


Description
-------

On a cluster with ambari-metrics in distributed operation mode, after enabling Namenode HA, the amabri-metrics property for hbase.rootdir should point to hdfs://<Nameservice ID>, but it actually still points to the explicit Namenode. In the Enable HA wizard, the updated property with nameservice is shown, but when you go to Ambari Metrics Config properties, hbase.rootdir still points to the old value.


This is happening because while enabling name node HA, AMS needs to be reconfigured and the hbase.rootdir config property in ams-hbase-site needs to be updated to use the nameservice similar to other services such as HBase, Accumulo etc.


Diffs
-----

  ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js fc44724 
  ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 713e1c3 
  ambari-web/app/messages.js 8ff4b55 
  ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js 10989e0 

Diff: https://reviews.apache.org/r/54911/diff/


Testing
-------

Manual Testing. Tested enabling HA with both distributed and embedded operation mode for AMS.
Also updated test case.

Patch failure with hadoop qa is unrelated.


File Attachments
----------------

AMBARI-19206.patch
  https://reviews.apache.org/media/uploaded/files/2016/12/20/611ff5b0-1bf2-4b3c-a697-a69e7c1220d2__AMBARI-19206.patch


Thanks,

Sangeeta Ravindran


Re: Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54911/#review159782
-----------------------------------------------------------


Ship it!




Ship It!

- Alexandr Antonenko


On Dec. 20, 2016, 8:53 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54911/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 8:53 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-19206
>     https://issues.apache.org/jira/browse/AMBARI-19206
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On a cluster with ambari-metrics in distributed operation mode, after enabling Namenode HA, the amabri-metrics property for hbase.rootdir should point to hdfs://<Nameservice ID>, but it actually still points to the explicit Namenode. In the Enable HA wizard, the updated property with nameservice is shown, but when you go to Ambari Metrics Config properties, hbase.rootdir still points to the old value.
> 
> 
> This is happening because while enabling name node HA, AMS needs to be reconfigured and the hbase.rootdir config property in ams-hbase-site needs to be updated to use the nameservice similar to other services such as HBase, Accumulo etc.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js fc44724 
>   ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 713e1c3 
>   ambari-web/app/messages.js 8ff4b55 
>   ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js 10989e0 
> 
> Diff: https://reviews.apache.org/r/54911/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing. Tested enabling HA with both distributed and embedded operation mode for AMS.
> Also updated test case.
> 
> Patch failure with hadoop qa is unrelated.
> 
> 
> File Attachments
> ----------------
> 
> AMBARI-19206.patch
>   https://reviews.apache.org/media/uploaded/files/2016/12/20/611ff5b0-1bf2-4b3c-a697-a69e7c1220d2__AMBARI-19206.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>


Re: Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54911/#review159806
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On Dec. 20, 2016, 8:53 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54911/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 8:53 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-19206
>     https://issues.apache.org/jira/browse/AMBARI-19206
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On a cluster with ambari-metrics in distributed operation mode, after enabling Namenode HA, the amabri-metrics property for hbase.rootdir should point to hdfs://<Nameservice ID>, but it actually still points to the explicit Namenode. In the Enable HA wizard, the updated property with nameservice is shown, but when you go to Ambari Metrics Config properties, hbase.rootdir still points to the old value.
> 
> 
> This is happening because while enabling name node HA, AMS needs to be reconfigured and the hbase.rootdir config property in ams-hbase-site needs to be updated to use the nameservice similar to other services such as HBase, Accumulo etc.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js fc44724 
>   ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 713e1c3 
>   ambari-web/app/messages.js 8ff4b55 
>   ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js 10989e0 
> 
> Diff: https://reviews.apache.org/r/54911/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing. Tested enabling HA with both distributed and embedded operation mode for AMS.
> Also updated test case.
> 
> Patch failure with hadoop qa is unrelated.
> 
> 
> File Attachments
> ----------------
> 
> AMBARI-19206.patch
>   https://reviews.apache.org/media/uploaded/files/2016/12/20/611ff5b0-1bf2-4b3c-a697-a69e7c1220d2__AMBARI-19206.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>


Re: Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

Posted by Sangeeta Ravindran <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54911/
-----------------------------------------------------------

(Updated Dec. 20, 2016, 8:53 p.m.)


Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-19206
    https://issues.apache.org/jira/browse/AMBARI-19206


Repository: ambari


Description
-------

On a cluster with ambari-metrics in distributed operation mode, after enabling Namenode HA, the amabri-metrics property for hbase.rootdir should point to hdfs://<Nameservice ID>, but it actually still points to the explicit Namenode. In the Enable HA wizard, the updated property with nameservice is shown, but when you go to Ambari Metrics Config properties, hbase.rootdir still points to the old value.


This is happening because while enabling name node HA, AMS needs to be reconfigured and the hbase.rootdir config property in ams-hbase-site needs to be updated to use the nameservice similar to other services such as HBase, Accumulo etc.


Diffs
-----

  ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js fc44724 
  ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 713e1c3 
  ambari-web/app/messages.js 8ff4b55 
  ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js 10989e0 

Diff: https://reviews.apache.org/r/54911/diff/


Testing
-------

Manual Testing. Tested enabling HA with both distributed and embedded operation mode for AMS.
Also updated test case.

Patch failure with hadoop qa is unrelated.


File Attachments
----------------

AMBARI-19206.patch
  https://reviews.apache.org/media/uploaded/files/2016/12/20/611ff5b0-1bf2-4b3c-a697-a69e7c1220d2__AMBARI-19206.patch


Thanks,

Sangeeta Ravindran