You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by ushachar <gi...@git.apache.org> on 2016/06/08 21:00:06 UTC

[GitHub] trafficserver pull request #699: TS-4514: Transaction hangs when no_dns_just...

GitHub user ushachar opened a pull request:

    https://github.com/apache/trafficserver/pull/699

    TS-4514: Transaction hangs when no_dns_just_forward is configured but\u2026

    \u2026 parent proxy is unresolvable
    
    It doesn't really make sense for the parent selection layer to be aware of the no_dns flag.
    Calling code handles takes the flag into account.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ushachar/trafficserver fix_dns_loop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/699.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #699
    
----
commit dabf2c1d118a78884164f529d37015ba1780bade
Author: Uri Shachar <us...@apache.org>
Date:   2016-06-08T20:44:19Z

    TS-4514: Transaction hangs when no_dns_just_forward is configured but parent proxy is unresolvable
    
    It doesn't really make sense for the parent selection layer to be aware of the no_dns flag.
    Calling code handles takes the flag into account.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    [approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/212/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    Testing: [approve ci] 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by ushachar <gi...@git.apache.org>.
Github user ushachar commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    BSD CI failure appears to be due to compiling the wrong code??
    boom.cc:415:21: error: unused variable 'pboom' [-Werror,-Wunused-variable]
      BoomGlobalPlugin *pboom = new BoomGlobalPlugin(pregistry);
    
    but boom.cc doesn't contain that line in my branch or in master....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    I manually triggered building this PR, and then they both completed. I'll keep looking into what is wrong with the auto-triggered builds, this is a huge PITA :-/.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    @ushachar  I think that worked, can you verify that those two builds are as you expected ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/191/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    Ya, I think Jenkins is totally busted :-/. I see these things, and I have no idea why:
    
        Multiple candidate revisions
        Scheduling another build to catch up with Github-Linux
        Checking out Revision 32054742d554c8057370929d44900a73745ee5b8 (origin/pr/36/merge)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by ushachar <gi...@git.apache.org>.
Github user ushachar commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    @zwoop  -- Yep, the pulled hashes look right....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/103/ for details.
    Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/103/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #699: TS-4514: Transaction hangs when no_dns_just_forwar...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/699
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/109/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #699: TS-4514: Transaction hangs when no_dns_just...

Posted by ushachar <gi...@git.apache.org>.
Github user ushachar closed the pull request at:

    https://github.com/apache/trafficserver/pull/699


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---