You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/07/24 03:50:35 UTC
[GitHub] [incubator-iceberg] timmylicheng edited a comment on issue #295:
Normalize NaN values for bucketing
timmylicheng edited a comment on issue #295: Normalize NaN values for bucketing
URL: https://github.com/apache/incubator-iceberg/issues/295#issuecomment-514468427
There is a short description in spec.md on this "2. Float hash values are the result of hashing the float cast to double to ensure that schema evolution does not change hash values if float types are promoted. Note that floating point types are not valid source values for partitioning."
But I agree with you. Having the comments saying bucketing by float or double is not allowed, the actual implementation seems useless.
How about I remove the description in spec.md as well as BucketFloat and BucketDouble class?
@rdblue Thoughts? Saw your initial commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org