You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by al...@apache.org on 2021/11/09 11:39:54 UTC
[arrow-rs] branch cherry_pick_08925959 created (now 77114d5)
This is an automated email from the ASF dual-hosted git repository.
alamb pushed a change to branch cherry_pick_08925959
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git.
at 77114d5 Do not use cache for miri
This branch includes the following new commits:
new cb58491 Automatically retry failed MIRI runs to work around intermittent failures (#922)
new 77114d5 Do not use cache for miri
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[arrow-rs] 02/02: Do not use cache for miri
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch cherry_pick_08925959
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
commit 77114d58f1e26e3e2bc45d5ea82ce44f65195f83
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Tue Nov 9 06:39:41 2021 -0500
Do not use cache for miri
---
.github/workflows/miri.yaml | 7 -------
1 file changed, 7 deletions(-)
diff --git a/.github/workflows/miri.yaml b/.github/workflows/miri.yaml
index 373f24c..7856bec 100644
--- a/.github/workflows/miri.yaml
+++ b/.github/workflows/miri.yaml
@@ -35,13 +35,6 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/cache@v2
- with:
- path: |
- ~/.cargo/registry
- ~/.cargo/git
- target
- key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
- name: Setup Rust toolchain
run: |
rustup toolchain install ${{ matrix.rust }}
[arrow-rs] 01/02: Automatically retry failed MIRI runs to work
around intermittent failures (#922)
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch cherry_pick_08925959
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
commit cb5849188c5d386368532f03600aef5372b5270e
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Sat Nov 6 05:55:53 2021 -0400
Automatically retry failed MIRI runs to work around intermittent failures (#922)
* Move MIRI checks into a shell script
* add retry loop
---
.github/workflows/miri.sh | 26 ++++++++++++++++++++++++++
.github/workflows/miri.yaml | 7 +------
2 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/.github/workflows/miri.sh b/.github/workflows/miri.sh
new file mode 100755
index 0000000..27c6f5e
--- /dev/null
+++ b/.github/workflows/miri.sh
@@ -0,0 +1,26 @@
+#!/bin/bash
+#
+# Script
+#
+# Must be run with nightly rust for example
+# rustup default nightly
+
+
+export MIRIFLAGS="-Zmiri-disable-isolation"
+cargo miri setup
+cargo clean
+
+run_miri() {
+ # Currently only the arrow crate is tested with miri
+ # IO related tests and some unsupported tests are skipped
+ cargo miri test -p arrow -- --skip csv --skip ipc --skip json
+}
+
+# If MIRI fails, automatically retry
+# Seems like miri is occasionally killed by the github runner
+# https://github.com/apache/arrow-rs/issues/879
+for i in `seq 1 5`; do
+ echo "Starting Arrow MIRI run..."
+ run_miri && break
+ echo "foo" > /tmp/data.txt
+done
diff --git a/.github/workflows/miri.yaml b/.github/workflows/miri.yaml
index 136b0e1..373f24c 100644
--- a/.github/workflows/miri.yaml
+++ b/.github/workflows/miri.yaml
@@ -52,9 +52,4 @@ jobs:
RUST_BACKTRACE: full
RUST_LOG: 'trace'
run: |
- export MIRIFLAGS="-Zmiri-disable-isolation"
- cargo miri setup
- cargo clean
- # Currently only the arrow crate is tested with miri
- # IO related tests and some unsupported tests are skipped
- cargo miri test -p arrow -- --skip csv --skip ipc --skip json
+ bash .github/workflows/miri.sh