You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2005/06/14 15:33:07 UTC
Re: "svn lock" process return code (Subversion 1.2 RC2 Win32)
On Sat, 2005-05-07 at 13:15 +0200, Peter N. Lundblad wrote:
> So if you say
> svn lock a b
> and a was already locked, it continues with b. If the latter lock
> operation succeeds, should it return success or failer? Maybe someone on
> dev@ has an opinion.
Sure, I have an opinion. "svn lock a b" should return success if a and
b are locked by the working copy upon completion.
So, if a was already locked by someone else, the result should be
failure. If a was already locked by this working copy, the result
should be success.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: "svn lock" process return code (Subversion 1.2 RC2 Win32)
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Tue, 14 Jun 2005, Greg Hudson wrote:
> On Sat, 2005-05-07 at 13:15 +0200, Peter N. Lundblad wrote:
> > So if you say
> > svn lock a b
> > and a was already locked, it continues with b. If the latter lock
> > operation succeeds, should it return success or failer? Maybe someone on
> > dev@ has an opinion.
>
> Sure, I have an opinion. "svn lock a b" should return success if a and
> b are locked by the working copy upon completion.
>
> So, if a was already locked by someone else, the result should be
> failure. If a was already locked by this working copy, the result
> should be success.
>
Seems logicla to me. I think the problem is that the locking functions
choose to continue on some errors that should really be fatal. Seems like
this needs some reworking. Not sure if there is an issue for this.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: "svn lock" process return code (Subversion 1.2 RC2 Win32)
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Tue, 14 Jun 2005, Greg Hudson wrote:
> On Sat, 2005-05-07 at 13:15 +0200, Peter N. Lundblad wrote:
> > So if you say
> > svn lock a b
> > and a was already locked, it continues with b. If the latter lock
> > operation succeeds, should it return success or failer? Maybe someone on
> > dev@ has an opinion.
>
> Sure, I have an opinion. "svn lock a b" should return success if a and
> b are locked by the working copy upon completion.
>
> So, if a was already locked by someone else, the result should be
> failure. If a was already locked by this working copy, the result
> should be success.
>
Seems logicla to me. I think the problem is that the locking functions
choose to continue on some errors that should really be fatal. Seems like
this needs some reworking. Not sure if there is an issue for this.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org