You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by bo...@apache.org on 2010/03/29 12:22:32 UTC
svn commit: r928683 - in
/myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag:
SheetRenderer.java TextAreaRenderer.java
Author: bommel
Date: Mon Mar 29 10:22:32 2010
New Revision: 928683
URL: http://svn.apache.org/viewvc?rev=928683&view=rev
Log:
(TOBAGO-865) revert commit
checkstyle
Modified:
myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java
myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TextAreaRenderer.java
Modified: myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java?rev=928683&r1=928682&r2=928683&view=diff
==============================================================================
--- myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java (original)
+++ myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java Mon Mar 29 10:22:32 2010
@@ -29,14 +29,11 @@ import org.apache.myfaces.tobago.compone
import org.apache.myfaces.tobago.component.UIMenuCommand;
import org.apache.myfaces.tobago.component.UIReload;
import org.apache.myfaces.tobago.component.UISheet;
-import org.apache.myfaces.tobago.config.TobagoConfig;
import org.apache.myfaces.tobago.context.ResourceManager;
import org.apache.myfaces.tobago.context.ResourceManagerFactory;
import org.apache.myfaces.tobago.context.ResourceManagerUtil;
import org.apache.myfaces.tobago.context.TobagoFacesContext;
import org.apache.myfaces.tobago.event.PageAction;
-import org.apache.myfaces.tobago.internal.ajax.AjaxInternalUtils;
-import org.apache.myfaces.tobago.internal.ajax.AjaxRenderer;
import org.apache.myfaces.tobago.internal.util.StringUtils;
import org.apache.myfaces.tobago.layout.AutoLayoutToken;
import org.apache.myfaces.tobago.layout.LayoutBase;
Modified: myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TextAreaRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TextAreaRenderer.java?rev=928683&r1=928682&r2=928683&view=diff
==============================================================================
--- myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TextAreaRenderer.java (original)
+++ myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TextAreaRenderer.java Mon Mar 29 10:22:32 2010
@@ -26,7 +26,7 @@ import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.myfaces.tobago.component.Attributes;
import org.apache.myfaces.tobago.component.UITextarea;
-import org.apache.myfaces.tobago.context.Capability;
+//import org.apache.myfaces.tobago.context.Capability;
import org.apache.myfaces.tobago.renderkit.HtmlUtils;
import org.apache.myfaces.tobago.renderkit.InputRendererBase;
import org.apache.myfaces.tobago.renderkit.css.Style;
@@ -36,7 +36,7 @@ import org.apache.myfaces.tobago.renderk
import org.apache.myfaces.tobago.renderkit.html.util.HtmlRendererUtils;
import org.apache.myfaces.tobago.renderkit.util.RenderUtil;
import org.apache.myfaces.tobago.util.ComponentUtils;
-import org.apache.myfaces.tobago.util.VariableResolverUtils;
+//import org.apache.myfaces.tobago.util.VariableResolverUtils;
import org.apache.myfaces.tobago.webapp.TobagoResponseWriter;
import javax.faces.component.UIComponent;
@@ -84,7 +84,7 @@ public class TextAreaRenderer extends In
if (onchange != null) {
writer.writeAttribute(HtmlAttributes.ONCHANGE, onchange, null);
}
- int maxLength = -1;
+ /*int maxLength = -1;
for (Validator validator : input.getValidators()) {
if (validator instanceof LengthValidator) {
LengthValidator lengthValidator = (LengthValidator) validator;
@@ -97,7 +97,7 @@ public class TextAreaRenderer extends In
String placeholder = input.getPlaceholder();
if (placeholder != null) {
writer.writeAttribute(HtmlAttributes.PLACEHOLDER, placeholder, true);
- }
+ }*/
String currentValue = RenderUtil.currentValue(input);
if (currentValue != null) {
// this is because browsers eat the first CR+LF of <textarea>
@@ -111,22 +111,28 @@ public class TextAreaRenderer extends In
writer.writeText(currentValue, null);
}
writer.endElement(HtmlConstants.TEXTAREA);
- if (placeholder != null && !VariableResolverUtils.resolveClientProperties(facesContext)
+ /*if (placeholder != null && !VariableResolverUtils.resolveClientProperties(facesContext)
.getUserAgent().hasCapability(Capability.PLACEHOLDER)) {
HtmlRendererUtils.createPlaceholderDiv(input, currentValue, placeholder, style, writer);
- }
+ }*/
HtmlRendererUtils.checkForCommandFacet(input, facesContext, writer);
-
+ int maxLength = -1;
+ for (Validator validator : input.getValidators()) {
+ if (validator instanceof LengthValidator) {
+ LengthValidator lengthValidator = (LengthValidator) validator;
+ maxLength = lengthValidator.getMaximum();
+ }
+ }
boolean required = ComponentUtils.getBooleanAttribute(input, Attributes.REQUIRED);
- /*if (required || maxLength > 0) {
+ if (required || maxLength > 0) {
String rendererName = HtmlRendererUtils.getRendererName(facesContext, input);
final String[] cmds = {
"new Tobago.In(\"" + input.getClientId(facesContext) + "\", true ,\""
+ StyleClasses.PREFIX + rendererName + "\" " + (maxLength > -1? "," + maxLength: "") + " );"
};
HtmlRendererUtils.writeScriptLoader(facesContext, null, cmds);
- } */
+ }
// focus
HtmlRendererUtils.renderFocusId(facesContext, input);