You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2019/09/11 15:58:00 UTC
[jira] [Commented] (ARROW-6531) [C++] Do not always close raw
OutputStream in BufferedOutputStream::Close
[ https://issues.apache.org/jira/browse/ARROW-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927713#comment-16927713 ]
Antoine Pitrou commented on ARROW-6531:
---------------------------------------
Instead we can provide a {{Detach}} method that returns the raw stream and marks the buffered stream closed without closing the raw stream.
> [C++] Do not always close raw OutputStream in BufferedOutputStream::Close
> -------------------------------------------------------------------------
>
> Key: ARROW-6531
> URL: https://issues.apache.org/jira/browse/ARROW-6531
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Priority: Major
> Fix For: 0.15.0
>
>
> {{BufferedOutputStream::Close}} closes the raw file handle unconditionally. This may be undesirable in some circumstances.
> Some alternatives:
> * Do not close it
> * Only close it if the {{use_count}} of the {{shared_ptr}} is 1, so we know that no one else has a copy of the shared_ptr
--
This message was sent by Atlassian Jira
(v8.3.2#803003)