[GitHub] [yunikorn-core] pbacsko commented on pull request #562: [YUNIKORN-1799] Create basic ringbuffer implementation

["pbacsko (via GitHub)" <gi...@apache.org>]

pbacsko commented on PR #562:
URL: https://github.com/apache/yunikorn-core/pull/562#issuecomment-1587565779

   Just talked to Craig, it makes no sense to remove expired entries. It's better if we reach steady state in memory usage, so just keep the added elements, there's no harm if we don't remove those.
   
   In fact, I think storing `[]si.EventRecord` is preferable to `[]*si.EventRecord`. The only small issue is the map inside `si.Resource`, that must be copied manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org