[GitHub] eric-haibin-lin commented on a change in pull request #8470: Fix sparse dot test failure due to launching kernel when nnr = 0

[GitBox <gi...@apache.org>]

eric-haibin-lin commented on a change in pull request #8470: Fix sparse dot test failure due to launching kernel when nnr = 0
URL: https://github.com/apache/incubator-mxnet/pull/8470#discussion_r147854816
 
 

 ##########
 File path: tests/python/unittest/test_sparse_operator.py
 ##########
 @@ -1217,6 +1218,13 @@ def test_dot_csr(lhs_shape, rhs_shape, rhs_stype, trans_lhs, lhs_density, rhs_de
             test_dot_csr(lhs_shape, (lhs_shape[0], rnd.randint(1, 10)), 'row_sparse', True, lhs_d, rhs_d)
 
 
+def test_sparse_dot_twice():
 
 Review comment:
   Hmm. I'm curious why the existing unit tests don't detect this bug. 
   Also shall we write a test explicit test the root cause we found, instead of seeding numpy? Seeding is not reliable in my opinion - if someone else changed `test_sparse_dot ` with one more np random array created in the middle of the test, it might not still be testing what we wanted it to test on. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services