You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/06/12 18:44:27 UTC
[GitHub] flink pull request #4114: [FLINK-6903] [runtime] Activate checkstyle for run...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4114
[FLINK-6903] [runtime] Activate checkstyle for runtime/akka
Re-opening with corrected title.
@zentol I had this nearly done last week so am creating the pull request for when we are ready to review flink-runtime.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 6903_activate_checkstyle_for_runtime_akka
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4114
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4114: [FLINK-6903] [runtime] Activate checkstyle for runtime/ak...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4114
Can we add an exclusion for the logger? That should dramatically lower the changes needed; given the work on Flip-6 the existing JobManager/TaskManager will be removed eventually anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4114: [FLINK-6903] [runtime] Activate checkstyle for runtime/ak...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4114
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4114: [FLINK-6903] [runtime] Activate checkstyle for run...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4114: [FLINK-6903] [runtime] Activate checkstyle for runtime/ak...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4114
@zentol updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4114: [FLINK-6903] [runtime] Activate checkstyle for runtime/ak...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4114
@zentol is this worthwhile to review and commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---