[jira] [Commented] (OFBIZ-4346) Support MySQL and Postgres's LIMIT and OFFSET options

["Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144947#comment-13144947 ] 

Jacques Le Roux commented on OFBIZ-4346:
----------------------------------------

Reading http://www.postgresql.org/docs/9.0/static/sql-select.html#SQL-LIMIT, I wonder if we should not at least warn users (in makeOffsetString?) that they should be using ORDER BY. Else sounds good to me (1st review)
                
> Support MySQL and Postgres's LIMIT and OFFSET options
> -----------------------------------------------------
>
>                 Key: OFBIZ-4346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4346
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Shi Jinghai
>            Priority: Minor
>         Attachments: limit_offset_trunk, limit_offset_trunk.patch, mysql_postgres_limit_offset_trunk.patch
>
>
> Two helper classes are added for MySQL and Postgres to support LIMIT and OFFSET options.
> These classes can be configured in entityengine.xml:
> helper-class="org.ofbiz.entity.datasource.postgres.PostgresHelperDAO" for Postgres
> and
> helper-class="org.ofbiz.entity.datasource.mysql.MysqlHelperDAO" for MySQL.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira