You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "V.Narayanan (JIRA)" <ji...@apache.org> on 2007/04/06 11:23:32 UTC

[jira] Created: (DERBY-2529) Client PreparedStatement/CallableStatement implementations need to use locators

Client PreparedStatement/CallableStatement implementations need to use locators
-------------------------------------------------------------------------------

                 Key: DERBY-2529
                 URL: https://issues.apache.org/jira/browse/DERBY-2529
             Project: Derby
          Issue Type: Sub-task
            Reporter: V.Narayanan




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2529) Client PreparedStatement/CallableStatement implementations need to use locators

Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491284 ] 

V.Narayanan commented on DERBY-2529:
------------------------------------

I have been working on converting the following methods related to Blob to use locators.

setBytes
setBinaryStream
setBlob
setObject

setBlob and setObject are taken care of by the DRDA work done as part of
https://issues.apache.org/jira/browse/DERBY-2506. If the Blob object is
locator enabled then isLocator() would return true and the locator would
automatically be sent.

In the case of setBinaryStream, Layer B streaming is used to send the data
to the network server hence there is no significant performance improvement
in use a locator here to transfer the stream.

We neither need to change setBytes since in this case the overhead
of executing a stored procedure(BLOBCREATELOCATOR) to get a valid locator value,
then transferring the Bytes to the Blob(BLOBSETBYTES stored procedure) would
not be necessary when this can be done in one set of a Bytes transfer.

I expect a similar situation for Clob methods mentioned too.

I intend to close this JIRA as won't fix unless there is any objection
from the community.

> Client PreparedStatement/CallableStatement implementations need to use locators
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-2529
>                 URL: https://issues.apache.org/jira/browse/DERBY-2529
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2529) Client PreparedStatement/CallableStatement implementations need to use locators

Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487205 ] 

V.Narayanan commented on DERBY-2529:
------------------------------------

This can be divided into the set methods of PreparedStatement and get methods of CallableStatement because the CallableStatement implementation extends from the PreparedStatement implementation. The implementation of the set methods in the PreparedStatement would hence be inherited by the CallableStatement. 

The get methods in CallableStatement pass the efforts on to the Clob and Blob implementation. There is a seperate JIRA for locator support to Clob and Blob. 

Hence here we need to Convert the implementation of Clob and Blob related set methods of PreparedStatements in the NetworkClient to use locators.

Note that for backward compatibility the existing implementation of the methods
would need to co-exist with the locator implementation. 

The following are the methods that shall be converted to use locators. The list of methods
that are allowed to operate on the Blob column can be got from PossibleTypes
class in am/PreparedStatement.java

Blob
----
setBytes
setBinaryStream
setBlob
setObject (when a Blob is passed as parameter)

Clob
----
setString
setAsciiStream
setCharacterStream
setClob
setObject (When a Clob is passed as parameter)

The implementation will be done in two phases

PHASE 1 - Blob related methods
PHASE 2 - Clob related methods.

> Client PreparedStatement/CallableStatement implementations need to use locators
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-2529
>                 URL: https://issues.apache.org/jira/browse/DERBY-2529
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2529) Client PreparedStatement/CallableStatement implementations need to use locators

Posted by "Mike Matrigali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Matrigali updated DERBY-2529:
----------------------------------

    Component/s: Network Client

> Client PreparedStatement/CallableStatement implementations need to use locators
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-2529
>                 URL: https://issues.apache.org/jira/browse/DERBY-2529
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DERBY-2529) Client PreparedStatement/CallableStatement implementations need to use locators

Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

V.Narayanan reassigned DERBY-2529:
----------------------------------

    Assignee: V.Narayanan

> Client PreparedStatement/CallableStatement implementations need to use locators
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-2529
>                 URL: https://issues.apache.org/jira/browse/DERBY-2529
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-2529) Client PreparedStatement/CallableStatement implementations need to use locators

Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

V.Narayanan resolved DERBY-2529.
--------------------------------

       Resolution: Won't Fix
    Fix Version/s: 10.3.0.0

As indicated in my comments I am resolving this issue as won't fix. The reason as to why there is no patch needed in the context of PreparedStatement and CallableStatement can be found the sequence of comments of the issue.

> Client PreparedStatement/CallableStatement implementations need to use locators
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-2529
>                 URL: https://issues.apache.org/jira/browse/DERBY-2529
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>             Fix For: 10.3.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-2529) Client PreparedStatement/CallableStatement implementations need to use locators

Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

V.Narayanan closed DERBY-2529.
------------------------------


> Client PreparedStatement/CallableStatement implementations need to use locators
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-2529
>                 URL: https://issues.apache.org/jira/browse/DERBY-2529
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>             Fix For: 10.3.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.