[GitHub] [superset] justinpark commented on a diff in pull request #24418: fix: Native filter dynamic numeric search

["justinpark (via GitHub)" <gi...@apache.org>]

justinpark commented on code in PR #24418:
URL: https://github.com/apache/superset/pull/24418#discussion_r1232485627


##########
superset-frontend/src/filters/components/Select/buildQuery.test.ts:
##########
@@ -120,6 +120,8 @@ describe('Select buildQuery', () => {
     });
     expect(queryContext.queries.length).toEqual(1);
     const [query] = queryContext.queries;
-    expect(query.filters).toEqual([{ col: 'my_col', op: '>=', val: 123 }]);
+    expect(query.filters).toEqual([
+      { col: 'my_col', op: 'ILIKE', val: '%123%' },

Review Comment:
   btw i think `LIKE` can be enough for since it matches only numbers, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org