[jira] [Commented] (TEZ-2172) FetcherOrderedGrouped using List to store InputAttemptIdentifier can lead to some inefficiency during remove() operation

["Saikat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621328#comment-14621328 ] 

Saikat commented on TEZ-2172:
-----------------------------

[~rajesh.balamohan] I am interested in working on this JIRA. similar fix needed for UnorderedFetchers also.

> FetcherOrderedGrouped using List to store InputAttemptIdentifier can lead to some inefficiency during remove() operation
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-2172
>                 URL: https://issues.apache.org/jira/browse/TEZ-2172
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Saikat
>
> As part of fixing TEZ-2001, FetcherOrderedGrouped stores InputAttemptIdentifier in List.  This can lead to some inefficiency - since the size of this list can be ~30, and remove() calls can be expensive. 
> Option 1:  by using the spillId in the hashCode - or a wrapping structure for just this. However, SpillId can not be added to the hashCode as it would break ShuffleScheduler shuffleInfoEventsMap. 
> Option 2: consider using Map with an identifier. 
> Need to consider other options as well. Creating this jira as a placeholder to fix this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)