[GitHub] [fineract] ptuomola commented on pull request #2024: FINERACT-1492: Hikari configuration based on application properties

[GitBox <gi...@apache.org>]

ptuomola commented on pull request #2024:
URL: https://github.com/apache/fineract/pull/2024#issuecomment-1018414301


   Hi - I was looking at this and fully agree it's a great improvement - makes
   things a lot cleaner and simpler.
   
   The only concern I have is: it will break everyone's current configuration.
   
   Do you think it would make sense to make this change backward compatible?
   Ie use the same environment variables if they have been defined.
   
   On Fri, Jan 21, 2022, 18:46 Aleksandar Vidakovic ***@***.***>
   wrote:
   
   > @awasum <https://github.com/awasum> could you have a look at this please
   > and approve? Simplifies configuration. Thanks in advance :-)
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fineract/pull/2024#issuecomment-1018393053>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AASJVCQ7DD5NNIAIR4YAZZ3UXE2SHANCNFSM5MDXYSRA>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   > You are receiving this because your review was requested.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org