You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/11 10:22:05 UTC

[GitHub] [airflow] Taragolis opened a new pull request, #28290: Fix Google Cloud async tests

Taragolis opened a new pull request, #28290:
URL: https://github.com/apache/airflow/pull/28290

   Some async tests not properly mocked return objects
   - `tests/providers/google/cloud/hooks/test_cloud_composer.py`
   - `tests/providers/google/cloud/hooks/test_dataproc.py`
   
   Within `unittests.TestCase` it do actually nothing:
   ```console
    RuntimeWarning: coroutine 'FooBar.spam_egg' was never awaited method()
   ```
   
   When this tests migrate to `pytest` it raises different errors.
   
   This PR:
   - Move compat (with python 3.7) mockers to separate module
   - Migrate async tests to `pytest` and fix them


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #28290: Fix Google Cloud async tests

Posted by GitBox <gi...@apache.org>.

potiuk merged PR #28290:
URL: https://github.com/apache/airflow/pull/28290


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #28290: Fix Google Cloud async tests

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #28290:
URL: https://github.com/apache/airflow/pull/28290#issuecomment-1362778216

   Nice one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org