You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by nuttybrewer <gi...@git.apache.org> on 2015/10/29 10:07:22 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
GitHub user nuttybrewer opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/377
ZEPPELIN-365: Add credentials for dependency loader
Allow to authenticate to Artifactory or any other private maven repository using user/pass via the dependency loader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nuttybrewer/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit 0936e892c9138886645ec426b1e82b0bc390b15f
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:02:31Z
Added documentation for new addCredential() function
commit e7ece929d97ea58a729934733d5e0b43e103f220
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:03:06Z
Added addCredential() function to allow for authenticated repositories via dependency loader
commit 0c9395c65b3e6fbb97e2a04062e14bc7c79d994f
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:03:26Z
Merge branch 'master' of github.com:nuttybrewer/incubator-zeppelin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by nuttybrewer <gi...@git.apache.org>.
Github user nuttybrewer commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/377#issuecomment-152221063
Seems the CI environment is crashing with Bower... not related to my changes.. Should I resubmit the pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/377#issuecomment-154589150
Checked update of null value handling. LGTM.
Merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/377#issuecomment-153722573
Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by nuttybrewer <gi...@git.apache.org>.
GitHub user nuttybrewer reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/377
ZEPPELIN-365: Add credentials for dependency loader
Allow to authenticate to Artifactory or any other private maven repository using user/pass via the dependency loader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nuttybrewer/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit 0936e892c9138886645ec426b1e82b0bc390b15f
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:02:31Z
Added documentation for new addCredential() function
commit e7ece929d97ea58a729934733d5e0b43e103f220
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:03:06Z
Added addCredential() function to allow for authenticated repositories via dependency loader
commit 0c9395c65b3e6fbb97e2a04062e14bc7c79d994f
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:03:26Z
Merge branch 'master' of github.com:nuttybrewer/incubator-zeppelin
commit b93057d67ee2ab8c4a3f2fd171f5a2e4523e35d4
Author: nuttybrewer <nu...@gmail.com>
Date: 2015-10-29T18:25:00Z
remove return statement for coding style
commit 2b981650e7fda3d81e5e7f1b0a5ab9871c138706
Author: Patrick Ethier <nu...@gmail.com>
Date: 2015-10-31T18:49:17Z
Update DependencyContext.java
Clear the auths in the reset() function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by nuttybrewer <gi...@git.apache.org>.
GitHub user nuttybrewer reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/377
ZEPPELIN-365: Add credentials for dependency loader
Allow to authenticate to Artifactory or any other private maven repository using user/pass via the dependency loader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nuttybrewer/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit 0936e892c9138886645ec426b1e82b0bc390b15f
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:02:31Z
Added documentation for new addCredential() function
commit e7ece929d97ea58a729934733d5e0b43e103f220
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:03:06Z
Added addCredential() function to allow for authenticated repositories via dependency loader
commit 0c9395c65b3e6fbb97e2a04062e14bc7c79d994f
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:03:26Z
Merge branch 'master' of github.com:nuttybrewer/incubator-zeppelin
commit b93057d67ee2ab8c4a3f2fd171f5a2e4523e35d4
Author: nuttybrewer <nu...@gmail.com>
Date: 2015-10-29T18:25:00Z
remove return statement for coding style
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by nuttybrewer <gi...@git.apache.org>.
Github user nuttybrewer closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by nuttybrewer <gi...@git.apache.org>.
Github user nuttybrewer closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by nuttybrewer <gi...@git.apache.org>.
Github user nuttybrewer closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/377#issuecomment-153022069
How about API like
```
z.addRepo("RepoName").url("RepoURL").credential("username", "password")
```
Instead of
```
z.addRepo("RepoName").url("RepoURL")
z.addCredential("RepoName","username","password")
```
?
I think method chaining is more consistent design here while [Repository](https://github.com/apache/incubator-zeppelin/blob/master/spark/src/main/java/org/apache/zeppelin/spark/dep/Repository.java) already has url(), snapshot() with method chaining.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by nuttybrewer <gi...@git.apache.org>.
GitHub user nuttybrewer reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/377
ZEPPELIN-365: Add credentials for dependency loader
Allow to authenticate to Artifactory or any other private maven repository using user/pass via the dependency loader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nuttybrewer/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit 0936e892c9138886645ec426b1e82b0bc390b15f
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:02:31Z
Added documentation for new addCredential() function
commit e7ece929d97ea58a729934733d5e0b43e103f220
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:03:06Z
Added addCredential() function to allow for authenticated repositories via dependency loader
commit 0c9395c65b3e6fbb97e2a04062e14bc7c79d994f
Author: Patrick Ethier <pa...@secureops.com>
Date: 2015-10-29T09:03:26Z
Merge branch 'master' of github.com:nuttybrewer/incubator-zeppelin
commit b93057d67ee2ab8c4a3f2fd171f5a2e4523e35d4
Author: nuttybrewer <nu...@gmail.com>
Date: 2015-10-29T18:25:00Z
remove return statement for coding style
commit 2b981650e7fda3d81e5e7f1b0a5ab9871c138706
Author: Patrick Ethier <nu...@gmail.com>
Date: 2015-10-31T18:49:17Z
Update DependencyContext.java
Clear the auths in the reset() function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-365: Add credentials for...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/377#issuecomment-152236237
@nuttybrewer we're addressing https://issues.apache.org/jira/browse/ZEPPELIN-375 to make build pass on CI. Please trigger CI (close and open PR) when ZEPPELIN-375 is resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---