[GitHub] [incubator-paimon] zhangjun0x01 commented on a diff in pull request #1822: [flink] refactor update data fields process function

["zhangjun0x01 (via GitHub)" <gi...@apache.org>]

zhangjun0x01 commented on code in PR #1822:
URL: https://github.com/apache/incubator-paimon/pull/1822#discussion_r1295366323


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/cdc/MultiTableUpdatedDataFieldsProcessFunction.java:
##########
@@ -53,16 +47,17 @@
  * be 1.
  */
 public class MultiTableUpdatedDataFieldsProcessFunction
-        extends ProcessFunction<Tuple2<Identifier, List<DataField>>, Void> {
+        extends UpdatedDataFieldsBaseProcessFunction<Tuple2<Identifier, List<DataField>>, Void> {
 
     private static final Logger LOG =
             LoggerFactory.getLogger(MultiTableUpdatedDataFieldsProcessFunction.class);
 
     private final Map<Identifier, SchemaManager> schemaManagers = new HashMap<>();
-    private Catalog catalog;
+
     private final Catalog.Loader catalogLoader;
 
     public MultiTableUpdatedDataFieldsProcessFunction(Catalog.Loader catalogLoader) {
+        super(catalogLoader);
         this.catalogLoader = catalogLoader;

Review Comment:
   thanks for your suggestion, addressed it 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org