You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/31 04:41:00 UTC

[GitHub] [spark] williamhyun opened a new pull request #35077: [SPARK-37795][BUILD] Add a checkstyle rule to ban `org.apache.log4j` imports

williamhyun opened a new pull request #35077:
URL: https://github.com/apache/spark/pull/35077


   ### What changes were proposed in this pull request?
   This PR aims to add a new checkstyle rule to ban `org.apache.log4j` imports. 
   
   
   ### Why are the changes needed?
   This will help us remove the log4j bridge in the future. 
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Pass the CIs. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35077: [SPARK-37795][BUILD] Add a scalastyle rule to ban `org.apache.log4j` imports

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35077:
URL: https://github.com/apache/spark/pull/35077#issuecomment-1003410309


   Looks OK if you can get tests to pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #35077: [SPARK-37795][BUILD] Add a scalastyle rule to ban `org.apache.log4j` imports

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35077:
URL: https://github.com/apache/spark/pull/35077


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #35077: [SPARK-37795][BUILD] Add a scalastyle rule to ban `org.apache.log4j` imports

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35077:
URL: https://github.com/apache/spark/pull/35077#issuecomment-1003503460


   All tests passed and `sql - other tests` failure looks irrelevant because `scalastyle` is running at all GitHub Action SBT jobs.
   ```
    sql - other tests (JDK 8, hadoop3, hive2.3)
   ```
   
   Merged to master. Thank you, @williamhyun and @srowen .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org