You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org> on 2023/12/22 14:55:57 UTC
[PR] Savings and Deposits account with Undo Activation [fineract]
josehernandezfintecheandomx opened a new pull request, #3650:
URL: https://github.com/apache/fineract/pull/3650
## Description
Savings and Deposits account with Undo Activation
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
<img width="1496" alt="Screenshot 2023-12-22 at 8 19 37 a m" src="https://github.com/apache/fineract/assets/44206706/51159dc2-9722-4b09-a028-390ed27eac96">
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Savings and Deposits account with Undo Activation [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3650:
URL: https://github.com/apache/fineract/pull/3650#discussion_r1438867129
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -2387,7 +2387,49 @@ public void undoTransaction(final Long transactionId) {
}
}
- public void undoSavingsTransaction(final Long transactionId) {
+ protected Map<String, Object> undoActivate() {
+ final Map<String, Object> actualChanges = new LinkedHashMap<>();
+
+ final List<ApiParameterError> dataValidationErrors = new ArrayList<>();
+ final DataValidatorBuilder baseDataValidator = new DataValidatorBuilder(dataValidationErrors)
+ .resource(depositAccountType().resourceName() + SavingsApiConstants.undoActivateAction);
+
+ final SavingsAccountStatusType currentStatus = SavingsAccountStatusType.fromInt(this.status);
+ if (!SavingsAccountStatusType.ACTIVE.hasStateOf(currentStatus)) {
+ baseDataValidator.reset().parameter(SavingsApiConstants.activatedOnDateParamName)
+ .failWithCodeNoParameterAddedToErrorCode("not.in.active.state");
+
+ if (!dataValidationErrors.isEmpty()) {
+ throw new PlatformApiDataValidationException(dataValidationErrors);
+ }
+ }
+
+ final LocalDate businessDate = DateUtils.getBusinessLocalDate();;
+
+ this.status = SavingsAccountStatusType.APPROVED.getValue();
+ actualChanges.put(SavingsApiConstants.statusParamName, SavingsEnumerations.status(this.status));
+
+ this.rejectedOnDate = null;
+ this.rejectedBy = null;
+ this.withdrawnOnDate = null;
+ this.withdrawnBy = null;
+ this.closedOnDate = null;
+ this.closedBy = null;
+ this.activatedOnDate = null;
+ this.activatedBy = null;
+ this.lockedInUntilDate = null;
+
+ validateActivityNotBeforeClientOrGroupTransferDate(SavingsEvent.SAVINGS_UNOD_ACTIVATE, businessDate);
Review Comment:
Typo in the event name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Savings and Deposits account with Undo Activation [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3650: Savings and Deposits account with Undo Activation
URL: https://github.com/apache/fineract/pull/3650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Savings and Deposits account with Undo Activation [fineract]
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #3650:
URL: https://github.com/apache/fineract/pull/3650#issuecomment-1868897137
@josehernandezfintecheandomx ... please, proper PR title format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org