You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/05 02:56:01 UTC
[GitHub] [doris] morrySnow opened a new pull request, #10605: [enhancement](nereids) make filter node and join node work in Nereids
morrySnow opened a new pull request, #10605:
URL: https://github.com/apache/doris/pull/10605
# Proposed changes
enhancement
- add functions `finalizeForNereids` and `finalizeImplForNereids` in stale expression to generate some attributes using in BE.
- remove unnecessary parameter `Analyzer` in function `getBuiltinFunction`
- swap join condition if its left hand expression related to right table
- change join physical implementation to broadcast hash join
- add push predicate rule into planner
fix
- swap join children visit order to ensure the last fragment is root
- avoid visit join left child twice
known issues
- expression compute will generate a wrong answer when expression include arithmetic with two literal children.
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No
3. Has document been added or modified: No Need
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10605: [enhancement](nereids) make filter node and join node work in Nereids
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10605:
URL: https://github.com/apache/doris/pull/10605#issuecomment-1174863684
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 merged pull request #10605: [enhancement](nereids) make filter node and join node work in Nereids
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged PR #10605:
URL: https://github.com/apache/doris/pull/10605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 commented on a diff in pull request #10605: [enhancement](nereids) make filter node and join node work in Nereids
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #10605:
URL: https://github.com/apache/doris/pull/10605#discussion_r913579203
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java:
##########
@@ -62,8 +63,23 @@ public class ExpressionTranslator extends DefaultExpressionVisitor<Expr, PlanTra
public static ExpressionTranslator INSTANCE = new ExpressionTranslator();
- public static Expr translate(Expression expression, PlanTranslatorContext planContext) {
- return expression.accept(INSTANCE, planContext);
+ /**
+ * The entry function of ExpressionTranslator, call {@link Expr#finalizeForNereids()} to generate
+ * some attributes using in BE.
+ *
+ * @param expression nereids expression
+ * @param context translator context
+ * @return stale planner's expr
+ */
+ public static Expr translate(Expression expression, PlanTranslatorContext context) {
+ Expr staleExpr = expression.accept(INSTANCE, context);
+ try {
+ staleExpr.finalizeForNereids();
Review Comment:
```suggestion
staleExpr.analyzeForNereidsExpr();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10605: [enhancement](nereids) make filter node and join node work in Nereids
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10605:
URL: https://github.com/apache/doris/pull/10605#issuecomment-1174863625
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org