You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/07 05:38:05 UTC
[GitHub] [spark] gengliangwang opened a new pull request, #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
gengliangwang opened a new pull request, #38147:
URL: https://github.com/apache/spark/pull/38147
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
https://github.com/apache/spark/pull/38022 introduces an optional feature for supporting double-quoted identifiers. The feature is controlled by a flag `spark.sql.ansi.double_quoted_identifiers` which is independent from the flag `spark.sql.ansi.enabled`.
This is inconsistent with another ANSI SQL feature "Enforce ANSI reserved keywords": https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html#sql-keywords-optional-disabled-by-default, which is only available when `spark.sql.ansi.enabled` is true.
Thus, to make the ANSI flags consistent, I suggest making double-quoted identifiers only available under ANSI SQL mode.
Other than that, this PR renames it from `spark.sql.ansi.double_quoted_identifiers` to `spark.sql.ansi.doubleQuotedIdentifiers`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make the ANSI SQL related features consistent.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, the feature is not released yet.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New SQL test input file under ANSI mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r991831554
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
@cloud-fan Thanks for the suggestion. I updated the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r991794951
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
> non-ansi mode and double-quoted id enabled
I don't think so. This is a subconfig if ansi mode, and we only need to test the default case in non-ansi mode.
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
> non-ansi mode and double-quoted id enabled
I don't think so. This is a subconfig of ansi mode, and we only need to test the default case in non-ansi mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r990493388
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
I am seeing there is an extra testing here:
so this test file itself contains both `double_quoted_identifiers=false` and `double_quoted_identifiers=true` and now we run it into both ANSI and non-ANSI.
So I think what the unique testing coverage is:
1. non-ANSI and `double_quoted_identifiers=false`, so double quoted is still a string.
2. non-ANSI and `double_quoted_identifiers=true`, so we see parser exception.
3. ANSI and `double_quoted_identifiers=true`, this feature is on and being tested.
But for ANSI and `double_quoted_identifiers=false` which seems to be the same as number 2 above?
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
I am seeing there might be an extra testing here:
so this test file itself contains both `double_quoted_identifiers=false` and `double_quoted_identifiers=true` and now we run it into both ANSI and non-ANSI.
So I think what the unique testing coverage is:
1. non-ANSI and `double_quoted_identifiers=false`, so double quoted is still a string.
2. non-ANSI and `double_quoted_identifiers=true`, so we see parser exception.
3. ANSI and `double_quoted_identifiers=true`, this feature is on and being tested.
But for ANSI and `double_quoted_identifiers=false` which seems to be the same as number 2 above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r991521918
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
@cloud-fan so we at least need to test the 3 cases below:
* non-ansi mode and double-quoted id enabled
* ansi mode and double-quoted id enabled
* ansi mode and double-quoted id disabled
Any suggestion on the refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r991520849
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
> but also brings confusion: why do we test double_quoted_identifiers=false in ansi mode?
Do you mean "in non-ansi" mode?
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
> but also brings confusion: why do we test double_quoted_identifiers=false in ansi mode?
Do you mean "in non-ansi mode"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r991006165
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
I think it's time to refactor it now, as we run it again in the ansi mode tests.
It's not just unnecessary test time, but also brings confusion: why do we test `double_quoted_identifiers=false` in ansi mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #38147:
URL: https://github.com/apache/spark/pull/38147#issuecomment-1275055263
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r991794751
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
We can have a `double-quoted-identifiers.sql` without duplicate queries. In `.../inputs/ansi/`, we add 2 files to import the golden file with different configs
```
// file double-quoted-identifiers-enabled.sql
--SET spark.sql.ansi.double_quoted_identifiers = true
--IMPORT double-quoted-identifiers.sql
```
```
// file double-quoted-identifiers-disabled.sql
--SET spark.sql.ansi.double_quoted_identifiers = false
--IMPORT double-quoted-identifiers.sql
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r989698897
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2964,14 +2972,6 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
- val ENFORCE_RESERVED_KEYWORDS = buildConf("spark.sql.ansi.enforceReservedKeywords")
Review Comment:
Note related to this PR, but I move this code next to the ANSI_ENABLED flag for grouping the ANSI SQL related flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r990522343
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
Again, the test set is small. I don't see the downside of testing all the combinations.
Let's consider about reducing the tests when it becomes bigger, which is quite unlikely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r991794751
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
We can have a `double-quoted-identifiers.sql` without duplicate queries. In `.../inputs/ansi/`, we add 2 files to import the golden file with different configs
```
// file double-quoted-identifiers-enabled.sql
--SET spark.sql.ansi.doubleQuotedIdentifiers = true
--IMPORT double-quoted-identifiers.sql
```
```
// file double-quoted-identifiers-disabled.sql
--SET spark.sql.ansi.doubleQuotedIdentifiers = false
--IMPORT double-quoted-identifiers.sql
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
URL: https://github.com/apache/spark/pull/38147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #38147:
URL: https://github.com/apache/spark/pull/38147#issuecomment-1271133377
cc @srielau @entong as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r990137107
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
hmm, do we really need to run this SQL gold file in non-ansi mode? We will just see a bunch of parser errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r990299771
##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException
Review Comment:
I intend to ensure it won't work when ANSI mode is off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org