You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/27 06:45:53 UTC
[GitHub] [ozone] lokeshj1703 commented on a diff in pull request #3779: HDDS-7259. Fix uncounted blocksDeleted in BlockDeletingService
lokeshj1703 commented on code in PR #3779:
URL: https://github.com/apache/ozone/pull/3779#discussion_r980820606
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java:
##########
@@ -556,17 +556,26 @@ private Pair<Integer, Long> deleteTransactions(
LOG.warn("Missing delete block(Container = " +
container.getContainerData().getContainerID() + ", Block = " +
blkLong);
+ blocksDeleted++;
continue;
}
+
try {
handler.deleteBlock(container, blkInfo);
blocksDeleted++;
- bytesReleased += KeyValueContainerUtil.getBlockLength(blkInfo);
- } catch (InvalidProtocolBufferException e) {
- LOG.error("Failed to parse block info for block {}", blkLong, e);
} catch (IOException e) {
+ // TODO: if deletion of certain block retries exceed the certain
+ // number of times, service should skip deleting it,
+ // otherwise invalid numPendingDeletionBlocks could accumulate
+ // beyond the limit and the following deletion will stop.
Review Comment:
Have we run into an issue where block was throwing an error on deletion by the handler?
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java:
##########
@@ -556,17 +556,26 @@ private Pair<Integer, Long> deleteTransactions(
LOG.warn("Missing delete block(Container = " +
container.getContainerData().getContainerID() + ", Block = " +
blkLong);
+ blocksDeleted++;
Review Comment:
I do not think we should increment this when block is not found in the container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org