You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/16 16:25:46 UTC

[GitHub] [flink] ChengkaiYang2022 opened a new pull request, #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

ChengkaiYang2022 opened a new pull request, #19496:
URL: https://github.com/apache/flink/pull/19496

   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Translate "Metric Reporters" page of "Deployment" 
   
   
   ## Brief change log
   
   *(for example:)*
     - Translate some tables in this page .
   
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no) no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
     - The serializers: (yes / no / don't know) no 
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
     - The S3 file system connector: (yes / no / don't know) no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no) no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1100701349

   This pr is based on https://github.com/apache/flink/pull/19023.
   hi, @RocMarshal  I translate the tables and was able to run the website on my laptop. Please take a look thanks!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1114376209

   > @ChengkaiYang2022 sorry for the late check. Would you mind resolving the conflicts before the review work ? Thanks a lot.
   
   @RocMarshal ,I see some pr discussions to use rebase command instead of merge command and squash commits before do that. So Is that Okay I follow these steps?
   1. First, run `rebase -i Head~4`, to squash 4 commits in these PR into 1 commit and pust on my own remote branch.
   2. In my local branch,run `git fetch origin master` and git `rebase origin/master` to solve the conflicts.
   
   In the last [PR](https://github.com/apache/flink/pull/19023), I use the merge command and unable to squash the commits into one commit after merged.
   
   Would you mind give me more details about how to solve the conflict, or like should we squash commits at the end of the review or at the very beginning of the review? 
   I would like to have a clearer understanding of the community things, Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on code in PR #19496:
URL: https://github.com/apache/flink/pull/19496#discussion_r889923653


##########
docs/layouts/shortcodes/generated/metric_reporters_section_zh.html:
##########
@@ -0,0 +1,66 @@
+<table class="configuration table table-bordered">
+    <thead>
+        <tr>
+            <th class="text-left" style="width: 20%">键</th>
+            <th class="text-left" style="width: 15%">默认值</th>
+            <th class="text-left" style="width: 10%">数据类型</th>
+            <th class="text-left" style="width: 55%">描述</th>
+        </tr>
+    </thead>
+    <tbody>
+        <tr>
+            <td><h5>metrics.reporter.&lt;name&gt;.class</h5></td>

Review Comment:
   This item seems removed from the English version? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1100701397

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "059d23777a934337797c5e06227cc7c707e264d3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "059d23777a934337797c5e06227cc7c707e264d3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 059d23777a934337797c5e06227cc7c707e264d3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on code in PR #19496:
URL: https://github.com/apache/flink/pull/19496#discussion_r890256345


##########
docs/layouts/shortcodes/generated/metric_reporters_section_zh.html:
##########
@@ -0,0 +1,66 @@
+<table class="configuration table table-bordered">
+    <thead>
+        <tr>
+            <th class="text-left" style="width: 20%">键</th>
+            <th class="text-left" style="width: 15%">默认值</th>
+            <th class="text-left" style="width: 10%">数据类型</th>
+            <th class="text-left" style="width: 55%">描述</th>
+        </tr>
+    </thead>
+    <tbody>
+        <tr>
+            <td><h5>metrics.reporter.&lt;name&gt;.class</h5></td>

Review Comment:
   Fixed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1115132533

   @RocMarshal, I resolved the conflicts, here is the
   [link](http://localhost:1313/flink/flink-docs-master/zh/docs/deployment/metric_reporters/#%E5%8F%91%E9%80%81%E5%99%A8)
   ![Screenshot 2022-05-03 at 01-06-12 Metric Reporters](https://user-images.githubusercontent.com/8577744/166292437-e31bbf49-07e8-415e-b24e-ba855a9938e5.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1141674990

   @ChengkaiYang2022 Very thanks for the PR and sorry for the delay, I'll have a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on code in PR #19496:
URL: https://github.com/apache/flink/pull/19496#discussion_r863338247


##########
docs/content.zh/docs/deployment/metric_reporters.md:
##########
@@ -24,22 +24,24 @@ specific language governing permissions and limitations
 under the License.
 -->
 
+<a name="metric-reporters"></a>
+
 # Metric Reporters
 
-Flink allows reporting metrics to external systems.
-For more information about Flink's metric system go to the [metric system documentation]({{< ref "docs/ops/metrics" >}}).
+Flink 支持用户将 Flink 的各项运行时指标发送给外部系统。
+了解更多指标方面信息可查看 [metric 系统相关文档]({{< ref "docs/ops/metrics" >}})。
 
-Metrics can be exposed to an external system by configuring one or several reporters in `conf/flink-conf.yaml`. These
-reporters will be instantiated on each job and task manager when they are started.
+你可以通过 `conf/flink-conf.yaml` 文件来配置一种或多种发送器，将运行时指标暴露给外部系统。
+发送器会在 TaskManager、Flink 作业启动时进行实例化。
 
-Below is a list of parameters that are generally applicable to all reporters. All properties are configured by setting `metrics.reporter.<reporter_name>.<property>` in the configuration. Reporters may additionally offer implementation-specific parameters, which are documented in the respective reporter's section. 
+下面列出了所有发送器都适用的参数，可以通过配置文件中的 `metrics.reporter.<reporter_name>.<property>` 项进行配置。有些发送器有自己独特的配置，详见该发送器章节下的具体说明。

Review Comment:
   Thanks for that! Done



##########
docs/content.zh/docs/deployment/metric_reporters.md:
##########
@@ -163,46 +172,49 @@ metrics.reporter.influxdb.writeTimeout: 60000
 metrics.reporter.influxdb.interval: 60 SECONDS
 ```
 
-The reporter would send metrics using http protocol to the InfluxDB server with the specified retention policy (or the default policy specified on the server).
-All Flink metrics variables (see [List of all Variables]({{< ref "docs/ops/metrics" >}}#list-of-all-variables)) are exported as InfluxDB tags.
+InfluxDB 发送器会使用 http 协议按照将指标发送到 InfluxDB 服务器。指标的保留策略可通过配置指定，或按照 InfluxDB 服务端的保留策略决定。
+所有的 Flink 运行指标变量（见 [List of all Variables]({{< ref "docs/ops/metrics" >}}#list-of-all-variables)）都会按照 tag 形式上报给 InfluxDB。
+
+<a name="prometheus"></a>
 
 ### Prometheus
 #### (org.apache.flink.metrics.prometheus.PrometheusReporter)
 
-Type: pull/tags
+类型: pull/基于 tags 格式
 
-Parameters:
+参数：
 
-- `port` - (optional) the port the Prometheus exporter listens on, defaults to [9249](https://github.com/prometheus/prometheus/wiki/Default-port-allocations). In order to be able to run several instances of the reporter on one host (e.g. when one TaskManager is colocated with the JobManager) it is advisable to use a port range like `9250-9260`.
-- `filterLabelValueCharacters` - (optional) Specifies whether to filter label value characters. If enabled, all characters not matching \[a-zA-Z0-9:_\] will be removed, otherwise no characters will be removed. Before disabling this option please ensure that your label values meet the [Prometheus requirements](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels).
+- `port` - （可选的）Prometheus 发送器监听的端口，默认为 [9249](https://github.com/prometheus/prometheus/wiki/Default-port-allocations)。如果需要在一台机器上运行多个发送器示例进行监控时（比如 TaskManger 与 JobManager 在一台机器上运行时），建议将端口号配置为 `9250-9260` 这样的区间。
+- `filterLabelValueCharacters` -（可选的）指定是否过滤 label 中的非法字符。如果设置过滤，所有没有按照 \[a-zA-Z0-9:_\] 匹配的字符都会被过滤掉，如果设置不过滤，则不会有字符被过滤掉。设置不过滤前，请确保你的 label 符合 [Prometheus 的 lable 命名规范](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels)。
 
-Example configuration:
+配置示例：
 
 ```yaml
 metrics.reporter.prom.factory.class: org.apache.flink.metrics.prometheus.PrometheusReporterFactory
 ```
+Flink 指标类型与 Prometheus 指标类型对应关系如下：
 
-Flink metric types are mapped to Prometheus metric types as follows: 
+| Flink     | Prometheus | 注意事项                                  |
+| --------- |------------|-----------------------------------------|
+| Counter   | Gauge      | Prometheus 的 counter 不支持累加。         |
+| Gauge     | Gauge      | 只支持数字与布尔类型。                      |
+| Histogram | Summary    | 分位数为 .5, .75, .95, .98, .99 和 .999。  |

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1140390220

    Could you @leonardBang help to check it ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1141743076

   > @ChengkaiYang2022 Very thanks for the PR and sorry for the delay, I'll have a look
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii closed pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment" 
URL: https://github.com/apache/flink/pull/19496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on code in PR #19496:
URL: https://github.com/apache/flink/pull/19496#discussion_r890247851


##########
docs/layouts/shortcodes/generated/metric_reporters_section_zh.html:
##########
@@ -0,0 +1,66 @@
+<table class="configuration table table-bordered">
+    <thead>
+        <tr>
+            <th class="text-left" style="width: 20%">键</th>
+            <th class="text-left" style="width: 15%">默认值</th>
+            <th class="text-left" style="width: 10%">数据类型</th>
+            <th class="text-left" style="width: 55%">描述</th>
+        </tr>
+    </thead>
+    <tbody>
+        <tr>
+            <td><h5>metrics.reporter.&lt;name&gt;.class</h5></td>

Review Comment:
   Good Catch! It was removd in [this pr](https://github.com/apache/flink/pull/19444/files#diff-583daa5c9fb66f9f796e90e86956287fb60aea3cdc296471fc47276a7c80c1bb
   ) which solved
   [FLINK-27206](https://issues.apache.org/jira/browse/FLINK-27206).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] RocMarshal commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1100796251

   Cool~ @ChengkaiYang2022 . I'll check it ASAP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] RocMarshal commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1114256587

   @ChengkaiYang2022 sorry for the late check. Would you mind resolving the conflicts before the review work ? Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] RocMarshal commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on code in PR #19496:
URL: https://github.com/apache/flink/pull/19496#discussion_r863319045


##########
docs/content.zh/docs/deployment/metric_reporters.md:
##########
@@ -24,22 +24,24 @@ specific language governing permissions and limitations
 under the License.
 -->
 
+<a name="metric-reporters"></a>
+
 # Metric Reporters
 
-Flink allows reporting metrics to external systems.
-For more information about Flink's metric system go to the [metric system documentation]({{< ref "docs/ops/metrics" >}}).
+Flink 支持用户将 Flink 的各项运行时指标发送给外部系统。
+了解更多指标方面信息可查看 [metric 系统相关文档]({{< ref "docs/ops/metrics" >}})。
 
-Metrics can be exposed to an external system by configuring one or several reporters in `conf/flink-conf.yaml`. These
-reporters will be instantiated on each job and task manager when they are started.
+你可以通过 `conf/flink-conf.yaml` 文件来配置一种或多种发送器，将运行时指标暴露给外部系统。
+发送器会在 TaskManager、Flink 作业启动时进行实例化。
 
-Below is a list of parameters that are generally applicable to all reporters. All properties are configured by setting `metrics.reporter.<reporter_name>.<property>` in the configuration. Reporters may additionally offer implementation-specific parameters, which are documented in the respective reporter's section. 
+下面列出了所有发送器都适用的参数，可以通过配置文件中的 `metrics.reporter.<reporter_name>.<property>` 项进行配置。有些发送器有自己独特的配置，详见该发送器章节下的具体说明。

Review Comment:
   ```suggestion
   下面列出了所有发送器都适用的参数，可以通过配置文件中的 `metrics.reporter.<reporter_name>.<property>` 项进行配置。有些发送器有自己特有的配置，详见该发送器章节下的具体说明。
   ```



##########
docs/content.zh/docs/deployment/metric_reporters.md:
##########
@@ -237,28 +252,29 @@ metrics.reporter.stsd.port: 8125
 metrics.reporter.stsd.interval: 60 SECONDS
 ```
 
+<a name="datadog"></a>
+
 ### Datadog
 #### (org.apache.flink.metrics.datadog.DatadogHttpReporter)
 
-Type: push/tags
+类型: push/基于 tags 格式
 
-Note any variables in Flink metrics, such as `<host>`, `<job_name>`, `<tm_id>`, `<subtask_index>`, `<task_name>`, and `<operator_name>`,
-will be sent to Datadog as tags. Tags will look like `host:localhost` and `job_name:myjobname`.
+使用 Datadog 时，Flink 运行指标中的任何变量，例如`<host>`、`<job_name>`、 `<tm_id>`、 `<subtask_index>`、`<task_name>`、 `<operator_name>`，都会被当作`host:localhost`、`job_name:myjobname` 这样的 tag 发送。

Review Comment:
   ```suggestion
   使用 Datadog 时，Flink 运行指标中的任何变量，例如 `<host>`、`<job_name>`、 `<tm_id>`、 `<subtask_index>`、`<task_name>`、 `<operator_name>`，都会被当作 `host:localhost`、`job_name:myjobname` 这样的 tag 发送。
   ```



##########
docs/content.zh/docs/deployment/metric_reporters.md:
##########
@@ -163,46 +172,49 @@ metrics.reporter.influxdb.writeTimeout: 60000
 metrics.reporter.influxdb.interval: 60 SECONDS
 ```
 
-The reporter would send metrics using http protocol to the InfluxDB server with the specified retention policy (or the default policy specified on the server).
-All Flink metrics variables (see [List of all Variables]({{< ref "docs/ops/metrics" >}}#list-of-all-variables)) are exported as InfluxDB tags.
+InfluxDB 发送器会使用 http 协议按照将指标发送到 InfluxDB 服务器。指标的保留策略可通过配置指定，或按照 InfluxDB 服务端的保留策略决定。
+所有的 Flink 运行指标变量（见 [List of all Variables]({{< ref "docs/ops/metrics" >}}#list-of-all-variables)）都会按照 tag 形式上报给 InfluxDB。
+
+<a name="prometheus"></a>
 
 ### Prometheus
 #### (org.apache.flink.metrics.prometheus.PrometheusReporter)
 
-Type: pull/tags
+类型: pull/基于 tags 格式
 
-Parameters:
+参数：
 
-- `port` - (optional) the port the Prometheus exporter listens on, defaults to [9249](https://github.com/prometheus/prometheus/wiki/Default-port-allocations). In order to be able to run several instances of the reporter on one host (e.g. when one TaskManager is colocated with the JobManager) it is advisable to use a port range like `9250-9260`.
-- `filterLabelValueCharacters` - (optional) Specifies whether to filter label value characters. If enabled, all characters not matching \[a-zA-Z0-9:_\] will be removed, otherwise no characters will be removed. Before disabling this option please ensure that your label values meet the [Prometheus requirements](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels).
+- `port` - （可选的）Prometheus 发送器监听的端口，默认为 [9249](https://github.com/prometheus/prometheus/wiki/Default-port-allocations)。如果需要在一台机器上运行多个发送器示例进行监控时（比如 TaskManger 与 JobManager 在一台机器上运行时），建议将端口号配置为 `9250-9260` 这样的区间。
+- `filterLabelValueCharacters` -（可选的）指定是否过滤 label 中的非法字符。如果设置过滤，所有没有按照 \[a-zA-Z0-9:_\] 匹配的字符都会被过滤掉，如果设置不过滤，则不会有字符被过滤掉。设置不过滤前，请确保你的 label 符合 [Prometheus 的 lable 命名规范](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels)。
 
-Example configuration:
+配置示例：
 
 ```yaml
 metrics.reporter.prom.factory.class: org.apache.flink.metrics.prometheus.PrometheusReporterFactory
 ```
+Flink 指标类型与 Prometheus 指标类型对应关系如下：
 
-Flink metric types are mapped to Prometheus metric types as follows: 
+| Flink     | Prometheus | 注意事项                                  |
+| --------- |------------|-----------------------------------------|
+| Counter   | Gauge      | Prometheus 的 counter 不支持累加。         |
+| Gauge     | Gauge      | 只支持数字与布尔类型。                      |
+| Histogram | Summary    | 分位数为 .5, .75, .95, .98, .99 和 .999。  |

Review Comment:
   ```suggestion
   | Histogram | Summary    | 分位数为 .5，.75，.95，.98，.99 和 .999。  |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1110912963

   > Cool~ @ChengkaiYang2022 . I'll check it ASAP.
   
   Hi，@RocMarshal any update on your review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on code in PR #19496:
URL: https://github.com/apache/flink/pull/19496#discussion_r863338377


##########
docs/content.zh/docs/deployment/metric_reporters.md:
##########
@@ -237,28 +252,29 @@ metrics.reporter.stsd.port: 8125
 metrics.reporter.stsd.interval: 60 SECONDS
 ```
 
+<a name="datadog"></a>
+
 ### Datadog
 #### (org.apache.flink.metrics.datadog.DatadogHttpReporter)
 
-Type: push/tags
+类型: push/基于 tags 格式
 
-Note any variables in Flink metrics, such as `<host>`, `<job_name>`, `<tm_id>`, `<subtask_index>`, `<task_name>`, and `<operator_name>`,
-will be sent to Datadog as tags. Tags will look like `host:localhost` and `job_name:myjobname`.
+使用 Datadog 时，Flink 运行指标中的任何变量，例如`<host>`、`<job_name>`、 `<tm_id>`、 `<subtask_index>`、`<task_name>`、 `<operator_name>`，都会被当作`host:localhost`、`job_name:myjobname` 这样的 tag 发送。

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] RocMarshal commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1114756754

   Yes. Your description about the `squish` and `rebase` will work. Feel free go ahead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on PR #19496:
URL: https://github.com/apache/flink/pull/19496#issuecomment-1141754134

   > @ChengkaiYang2022 Very thanks for the PR and sorry for the delay, I'll have a look
   
   I understand that Flink's committer receives a lot of pending and review requests every day. 
   And I might be pending the wrong committer cause I'm not sure which committer is familiar or focused on the metric part.
   Also, thanks again for helping to review, and if there are any translation inaccuracies in the document, please let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on code in PR #19496:
URL: https://github.com/apache/flink/pull/19496#discussion_r890247851


##########
docs/layouts/shortcodes/generated/metric_reporters_section_zh.html:
##########
@@ -0,0 +1,66 @@
+<table class="configuration table table-bordered">
+    <thead>
+        <tr>
+            <th class="text-left" style="width: 20%">键</th>
+            <th class="text-left" style="width: 15%">默认值</th>
+            <th class="text-left" style="width: 10%">数据类型</th>
+            <th class="text-left" style="width: 55%">描述</th>
+        </tr>
+    </thead>
+    <tbody>
+        <tr>
+            <td><h5>metrics.reporter.&lt;name&gt;.class</h5></td>

Review Comment:
   Good Catch! It was removd in the [pr](https://github.com/apache/flink/pull/19444/files#diff-583daa5c9fb66f9f796e90e86956287fb60aea3cdc296471fc47276a7c80c1bb
   ) which solved
   [FLINK-27206](https://issues.apache.org/jira/browse/FLINK-27206).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on code in PR #19496:
URL: https://github.com/apache/flink/pull/19496#discussion_r890247851


##########
docs/layouts/shortcodes/generated/metric_reporters_section_zh.html:
##########
@@ -0,0 +1,66 @@
+<table class="configuration table table-bordered">
+    <thead>
+        <tr>
+            <th class="text-left" style="width: 20%">键</th>
+            <th class="text-left" style="width: 15%">默认值</th>
+            <th class="text-left" style="width: 10%">数据类型</th>
+            <th class="text-left" style="width: 55%">描述</th>
+        </tr>
+    </thead>
+    <tbody>
+        <tr>
+            <td><h5>metrics.reporter.&lt;name&gt;.class</h5></td>

Review Comment:
   Good Catch! It was removd in https://github.com/apache/flink/pull/19444/files#diff-583daa5c9fb66f9f796e90e86956287fb60aea3cdc296471fc47276a7c80c1bb



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

Posted by GitBox <gi...@apache.org>.
ChengkaiYang2022 commented on code in PR #19496:
URL: https://github.com/apache/flink/pull/19496#discussion_r890247851


##########
docs/layouts/shortcodes/generated/metric_reporters_section_zh.html:
##########
@@ -0,0 +1,66 @@
+<table class="configuration table table-bordered">
+    <thead>
+        <tr>
+            <th class="text-left" style="width: 20%">键</th>
+            <th class="text-left" style="width: 15%">默认值</th>
+            <th class="text-left" style="width: 10%">数据类型</th>
+            <th class="text-left" style="width: 55%">描述</th>
+        </tr>
+    </thead>
+    <tbody>
+        <tr>
+            <td><h5>metrics.reporter.&lt;name&gt;.class</h5></td>

Review Comment:
   Good Catch! It is removd in https://github.com/apache/flink/pull/19444/files#diff-583daa5c9fb66f9f796e90e86956287fb60aea3cdc296471fc47276a7c80c1bb



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org